Re: Would this be a break?

[Vincent Untz <vuntz gnome org>]

Le samedi 12 septembre 2009, à 13:27 +0200, Frederic Peters a écrit :
> Philippe Rouquier wrote:
> 
> > I just got a patch today that add a minor feature to brasero (see
> > https://bugzilla.gnome.org/show_bug.cgi?id=594954). Once applied the
> > patch allow brasero to emit a sound. the code is quite small but I was
> > wondering if it would be considered as a break for any of the freezes.
> > My main concern is also that it adds a new dependency though libcanberra
> > is part of the blessed external dependencies. What do you think?
> 
> IMHO it is a bit late to add a new dependency to an existing module,
> even if the patch is small (btw why is gtk_widget_show() added ?).

Agree. If it were really important, I would give a +1, but that's really
just a "would be nice" feature, so it's more appropriate to wait.

Vincent

-- 
Les gens heureux ne sont pas pressés.