Re: Would this be a break?
- From: Frederic Peters <fpeters gnome org>
- To: desktop-devel-list gnome org
- Subject: Re: Would this be a break?
- Date: Sat, 12 Sep 2009 13:27:29 +0200
Philippe Rouquier wrote:
> I just got a patch today that add a minor feature to brasero (see
> https://bugzilla.gnome.org/show_bug.cgi?id=594954). Once applied the
> patch allow brasero to emit a sound. the code is quite small but I was
> wondering if it would be considered as a break for any of the freezes.
> My main concern is also that it adds a new dependency though libcanberra
> is part of the blessed external dependencies. What do you think?
IMHO it is a bit late to add a new dependency to an existing module,
even if the patch is small (btw why is gtk_widget_show() added ?).
Other opinions are welcome,
] [Thread Prev