Re: GTK adjustement changes create incompatible behaviour between versions?

[Kjartan Maraas <kmaraas broadpark no>]

to., 18.09.2008 kl. 10.36 +0200, skrev Sebastien Bacher:
> Hello,
> 
> The new GTK 2.14 changed the way GtkAdjustements are working:
> 
> "* GtkAdjustment now enforces that values are restricted to the
>   range [lower, upper - page_size]. This has always been the documented
>   behaviour, and the recommended practice is to set page_size to 0
>   when using adjustments for simple scalar values, like in a slider
>   or spin button. "
> 
> That's the GTK readme stating that the new behaviour is documented but
> the GTK API example use non null values in its example and lot of
> applications seem to be in this case too.
> 
> That creates a collection of bugs,
> http://bugzilla.gnome.org/show_bug.cgi?id=551740 has a small discussion
> on the topic, basically the gtk_spin_buttons limits are broken in lot of
> applications (some example are on the bug, gnome-panel has similar
> issues too). That also means that applications need source code changes
> to be adapted to the new GTK behaviour.
> 
> Would it be possible to reconsider this change? That's somewhat a
> compatibility breakage and will create issues in lot of softwares. 
> If the change is right it would be nice to let a cycle for applications
> to be updated to the new behaviour before using it, there is thousand of
> GTK applications around and reviewing those for incorrect adjustement
> usages is going to take a while.
> 

Here's the list from my fedora rawhide install:

[kmaraas localhost share]$ find . -name *.ui | xargs grep page_size
./totem/mozilla-viewer.ui:    <property name="page_size">0</property>
./gnome-terminal/profile-preferences.ui:    <property name="page_size">0</property>
./gnome-terminal/profile-preferences.ui:    <property name="page_size">0</property>
./gnome-applets/builder/mini-commander.ui:    <property name="page_size">10</property>
./gnome-applets/builder/stickynotes.ui:    <property name="page_size">100</property>
./gnome-applets/builder/stickynotes.ui:    <property name="page_size">100</property>
./gedit-2/ui/gedit-print-preferences.ui:    <property name="page_size">10</property>
./gedit-2/ui/gedit-preferences-dialog.ui:    <property name="page_size">10</property>
./gedit-2/ui/gedit-preferences-dialog.ui:    <property name="page_size">8</property>
./gedit-2/ui/gedit-preferences-dialog.ui:    <property name="page_size">10</property>
./gedit-2/plugins/sort/sort.ui:    <property name="page_size">10</property>

And from my jhbuild install I get these in addition:

./gnome-system-tools/ui/time.ui:    <property name="page_size">10</property>
./gnome-system-tools/ui/time.ui:    <property name="page_size">10</property>
./gnome-system-tools/ui/time.ui:    <property name="page_size">10</property>
./gnome-system-tools/ui/users.ui:    <property name="page_size">10</property>
./gnome-system-tools/ui/users.ui:    <property name="page_size">10</property>
./gnome-system-tools/ui/users.ui:    <property name="page_size">10</property>
./gnome-system-tools/ui/users.ui:    <property name="page_size">10</property>
./gnome-system-tools/ui/users.ui:    <property name="page_size">10</property>
./gnome-system-tools/ui/users.ui:    <property name="page_size">10</property>
./gnome-system-tools/ui/users.ui:    <property name="page_size">10</property>
./gnome-system-tools/ui/users.ui:    <property name="page_size">10</property>
./gnome-system-tools/ui/users.ui:    <property name="page_size">10</property>
./gnome-system-tools/ui/users.ui:    <property name="page_size">10</property>
./gnome-system-tools/ui/users.ui:    <property name="page_size">10</property>
./gnome-system-tools/ui/users.ui:    <property name="page_size">10</property>
./gnome-applets/builder/battstat_applet.ui:    <property name="page_size">5</property>

So for our own release this affects at least three modules it seems. 

Cheers
Kjartan