Thoughts on patch for gcalctool bug #448263

Jani Monoses has sent me a nice patch for gcalctool. See:
specifically the attachment:

"The patch makes the following changes:

- replace gnome_help_display_desktop() with code from libgnome. As a bonus this
 made both calls' to help error handling be consistent when by using a dialog.
- drop GnomeClient dependency which is only used for die callback that does
 gtk_main_quit() and is useless
- use gtk_init instead of gnome_program_init. bug-buddy functionality is lost
 but that does not seem very important for gcalctool. There were few crashers
 and the last was caught months ago by Ubuntu's apport not bug buddy.

This patch makes the current --enable-gnome switch redundant as the app becomes
plain GTK + gconf. On the box I tested it in, the number of linked DSOs dropped
from 69 to 36 and startup time improved noticeably."

Now anything that reduces the number of libraries I need to add two
numbers together from 69 to 36 seems like a fine idea to me, but the
potential downside is that there is no longer bug-buddy support.

Does anybody have any strong objections to this patch being committed
for the gcalctool v2.19.4 release tomorrow.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]