Re: MAINTAINERS in svn -- have it or no commit for you

On Fri, Aug 31, 2007 at 11:17:40PM +0200, Vincent Untz wrote:
> Le vendredi 31 août 2007, à 19:55 +0200, Olav Vitters a écrit :
> > On Sun, Aug 12, 2007 at 01:55:35AM +0200, Olav Vitters wrote:
> > > On Wed, Aug 08, 2007 at 12:36:28AM +0200, Olav Vitters wrote:
> > > > Note that the userid is really important. Otherwise ensure that the
> > > > E-mail address is the one your @svn.g.o alias forwards to.
> > > 
> > > I've made an pre-commit script which detects if a module has a valid
> > > /trunk/MAINTAINERS file. This currently isn't activated, however I might
> > > do this in future.
> > 
> > This has now been enabled. Means you cannot commit to modules without a
> > proper MAINTAINERS file. The rejection message points to an URL
> > explaining this.
> > You will be able to commit a proper MAINTAINERS file of course.
> > Note: that has to live in /trunk/MAINTAINERS! Nowhere else (well, ok if
> > you have it, but the pre-commit script doesn't look at it)!
> Does it also make it impossible for translators to commit? If yes, can
> we postpone this to after 2.20.0?

Depends on what you are asking. Someone interpreted this as
 "you have to be in MAINTAINERS or you cannot commit"
...which is not true. It is just that nobody cannot do a commit in a
module until it has a valid MAINTAINERS file.

Further, anyone can commit a proper MAINTAINERS file. As soon that is
done all commits will work (you could even combine the MAINTAINERS
commit with a bug fix)... but I can understand translators not wanting
to deal with that.

Oh, and for those who didn't see the initial discussion. The intention
with knowing exactly who our maintainers are (in a machine readable
way), is that we can contact these maintainers. This won't happen right
away, because we'll be using the $USERNAME at email
aliases. Meaning, if that alias points to the wrong email address isn't
up to date it'll still fail (which I hope to detect by checking the
email address in MAINTAINERS).

I don't want to postpone the pre-commit just yet. My goal (should be
achievable) is to have the new accounts system working by end of
September. If we don't have the maintainers machine readable *now*, it
means accounts gnome org will have to correct each module when a
maintainer requests it... which won't happen realistically.

Oh, and it is end of September because before that I'll have some time
to do it.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]