Re: gdm2 string freeze breakage

[Niall Power - Sun Microsystems Ireland <Niall Power Sun COM>]

Hi,

apologies for the inconvenience caused. I was not aware that
the HEAD branch was also the stable branch for this module?? 
I submitted my patch for review with the gdm maintainer, George
(<jirka 5z com> and got his approval for the patch before committing.
Regardless, I will be more careful in future. Sorry again.

George,
just so I don't create problems like this in the future; do we need to
tag the gdm2 main branch and have an unstable branch so new stuff can be
added without breaking code/string freezes?

Thanks,
Niall.

On Thu, 2003-04-10 at 21:11, Christian Rose wrote:
> There has recently been an unannounced string freeze breakage in
> gdm2 HEAD branch:
> 
> This seems to be the commit in daemon/slave.c that caused the
> unannounced string addition:
> 
> ----------------------------
> 1.167 <niall> 2003-04-10 04:55
> 2003-04-10 Niall Power <Niall Power Sun COM>
> 
> * config/gdm.conf.in, daemon/gdm.c, daemon/gdm.h daemon/slave.c,
> docs/C/gdm.xml: Add support for launching gdmlogin/gdmgreeter
> with a configurable list of gtk modules. Needed for accessibility.
> Adds two new options to gdm.conf: "AddGtkModules" (boolean) and
> "GtkModulesList" (string).
> 
> ----------------------------
> 
> This is the change:
> http://cvs.gnome.org/bonsai/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvs/gnome&subdir=gdm2/daemon&command=DIFF_FRAMESET&file=slave.c&rev2=1.167&rev1=1.166
> 
> Communication with translators regarding string changes at supposedly
> stable times is very important. We're way past doing any unannounced
> changes to messages in 2.2 code, even if it should be about bugfixes.
> It's not hard to send a mail to gnome-i18n gnome org warning translators
> about a message addition; please spend a few seconds doing so after
> doing such message additions or changes to string-frozen stable code.
> Thanks.
> 
> 
> Christian
-- 
Niall Power - Sun Microsystems Ireland <niall power sun com>