Re: patch to tasklist and libwnck

[textshell <textshell neutronstar dyndns org>]

On Sunday 12 May 2002 22:27, Thomas Vander Stichele wrote:
> Hi,
>
> > I see a problem here, your patch only addresses the problem in horizontal
> > panels, am i right? I think you should modify your patch so that it works
> > for the vertical orientation too. I admit the vertical case is not as
> > broken without a patch as the horizontal case. But the minumum height
> > hardcoded into the wla is not enough to be useful.
>
> Yes, Alex told me not to worry about vertical panels too much as long as
> it doesn't break stuff.  Could you please tell me how it is supposed to
> work as opposed to how it works with the patch ? So I can test and adapt.
>
For vertical panels it's the same as for horizontal ones. The only 
difference is in one case the user controls the width in the other the height.
Another difference if that horizontal panel get 0 as size in the unpatched 
applet and the vertical one 88(on my setup). Both are not enough to be useful.
So how it is supposed to work? We need to have some way to set a min/max 
height.

In my patch I simple had a fixed "size", which was used as height in vertical 
panels and as width in horizontal panel. Using one Option(or in your case one 
set{min/max}) is less cluttered.
So we could just have the code detect vertical orientation and use the 
settings as min/max height in that case. The user interface would have to be 
changed so that a) you just use size in the dialog or b) you replace width by 
height for vertical panels.

> > I think the two options you have added are enough, just make sure you
> > replace width through height in the UI and code for vertical panels.
> > (your default of 50 pixels minimum height would be less than the standard
> > 88 pixels, but this won't be a problem)
>
> Are you saying, use the same values for minimum and maximum "size" both
> for width and height ?
>
I think this would be reasonable. It doesn't break stuff, it's simple. And 
the dialog doesn't get overloaded with options.
You can make a new set of options for the width, but as the applets are 
supposed to use the size of the panel as one dimension, it would in most case 
be just an option without effect -> confusing.
But if you think that would be better feel free to do so.


Martin H.