Re: PATCH: panel run dialog redux
- From: Frank Worsley <fworsley shaw ca>
- To: Jonathan Blandford <jrb redhat com>
- Cc: desktop-devel-list gnome org, George <jirka 5z com>
- Subject: Re: PATCH: panel run dialog redux
- Date: Fri, 03 May 2002 14:31:06 -0700
> I applied the patch and had a couple comments:
Cool.
> 1) You need some better padding around the whole dialog. Also, when
> resizing the dialog you need to make sure the tree expands too. I
> think you want to turn off the separator in the dialog, too.
> Finally, we need to pick a better default height for the list. If
> and when this patch lands, I'll give some code to do this.
>
> 2) It might be nice to put the icon to the left of the entry. It would
> give a bit more color to the dialog when when the list isn't showing.
>
> 3) I really think that Alex's suggestion of changing the icon to match
> that in the entry would be really nice. It shouldn't be hard to do,
> either.
>
> 4) I think Havoc's suggestion of setting the window back to the minimum
> size when hiding the list is the right thing to do.
>
> 5) The browse button just seems to append the file picked to whatever is
> in the entry. Also, shouldn't you default the filesel dialog to
> /usr/bin/ or something?
>
Yeah I didn't really test this very much. ;)
I will send a cleaned up patch later today or tomorrow. I will also use
iain's widget instead of the button.
- Frank
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]