Re: [G2R] Re: clock instant-apply patch

[John Fleck <jfleck inkstain net>]

On Sat, Feb 23, 2002 at 09:00:39PM +0200, Gediminas Paulauskas wrote:
> Pn, 2002-02-22 03:53, Gediminas Paulauskas rašė:
> > Pr, 2002-02-18 18:07, fflewddur rašė:
> > > this patch updates the clock applet's properties dialog to use
> > > instant-apply settings.  could someone review/commit?  thanks!
> > 
> > This patch breaks UI freeze (but fortunately, not string freeze), but
> > without it this applet is inconsistent with all other dialogs in
> > gnome-panel, and is an improvement from usability POV.
> > 
> > However, bigger changes are needed to make it usable (like keynav). I
> > have put all issues into http://bugzilla.gnome.org/show_bug.cgi?id=72201
> > 
> > Would adding accelerators to all strings be accepted? How about other
> > changes proposed in that bugzilla ticket?
> > 
> > On related note, there are more string changes proposed:
> > http://bugzilla.gnome.org/show_bug.cgi?id=61586
> 
> OK, so I have taken it today, and rewritten clock applet properties just
> to make them work. Properties dialog has lost Apply,Cancel,OK buttons,
> and got just Close; was made instant-apply. Apart from that, there are
> no UI changes, and no string changes at all.
> 
> Since docs do not contain a screeshot of preferences dialog, I assume
> this patch is a must-go, but of course I need permission to commit.
> 


This looks OK from a docs perspective.

Cheers,

John