Re: clock instant-apply patch

[Gediminas Paulauskas <menesis delfi lt>]

Pn, 2002-02-22 03:53, Gediminas Paulauskas rašė:
> Pr, 2002-02-18 18:07, fflewddur rašė:
> > this patch updates the clock applet's properties dialog to use
> > instant-apply settings.  could someone review/commit?  thanks!
> 
> This patch breaks UI freeze (but fortunately, not string freeze), but
> without it this applet is inconsistent with all other dialogs in
> gnome-panel, and is an improvement from usability POV.
> 
> However, bigger changes are needed to make it usable (like keynav). I
> have put all issues into http://bugzilla.gnome.org/show_bug.cgi?id=72201
> 
> Would adding accelerators to all strings be accepted? How about other
> changes proposed in that bugzilla ticket?
> 
> On related note, there are more string changes proposed:
> http://bugzilla.gnome.org/show_bug.cgi?id=61586

OK, so I have taken it today, and rewritten clock applet properties just
to make them work. Properties dialog has lost Apply,Cancel,OK buttons,
and got just Close; was made instant-apply. Apart from that, there are
no UI changes, and no string changes at all.

Since docs do not contain a screeshot of preferences dialog, I assume
this patch is a must-go, but of course I need permission to commit.

-- 
Gediminas

Attachment: clock-properties.diff.gz
Description: GNU Zip compressed data

<gconfschemafile>
    <schemalist>    

      <schema>
        <key>/schemas/apps/clock-applet/prefs/hour_format</key>
        <owner>clock-applet</owner>
        <type>int</type>
        <default>24</default>
        <locale name="C">
          <short>Hour format</short>
          <long>Sets the hour format, may be either 12 or 24</long>
        </locale>
      </schema>
                 
      <schema>
        <key>/schemas/apps/clock-applet/prefs/show_date</key>
        <owner>clock-applet</owner>
        <type>bool</type>
        <default>true</default>
        <locale name="C">
          <short>Show date in applet</short>
          <long>Display date in applet, in addition to time</long>
        </locale>
      </schema>

      <schema>
        <key>/schemas/apps/clock-applet/prefs/show_tooltip</key>
        <owner>clock-applet</owner>
        <type>bool</type>
        <default>true</default>
        <locale name="C">
          <short>Show date in tooltip</short>
          <long>Show date in a tooltip when a mouse is over applet</long>
        </locale>
      </schema>
                 
      <schema>
        <key>/schemas/apps/clock-applet/prefs/gmt_time</key>
        <owner>clock-applet</owner>
        <type>bool</type>
        <default>false</default>
        <locale name="C">
          <short>Use GMT</short>
          <long>Display time in Greenwich Mean Time zone</long>
        </locale>
      </schema>
                 
      <schema>
        <key>/schemas/apps/clock-applet/prefs/unix_time</key>
        <owner>clock-applet</owner>
        <type>bool</type>
        <default>false</default>
        <locale name="C">
          <short>Use UNIX time</short>
          <long>Display time in seconds since Epoch, i.e. 1970-01-01</long>
        </locale>
      </schema>
                 
      <schema>
        <key>/schemas/apps/clock-applet/prefs/internet_time</key>
        <owner>clock-applet</owner>
        <type>bool</type>
        <default>false</default>
        <locale name="C">
          <short>Use Internet time</short>
          <long>Display Internet time, which is same all over the world</long>
        </locale>
      </schema>
                 
  </schemalist>
  
</gconfschemafile>