Re: branching of gnome-vfs-extras
- From: Alex Larsson <alexl redhat com>
- To: Bastien Nocera <hadess hadess net>
- Cc: GNOME Desktop Hackers <desktop-devel-list gnome org>
- Subject: Re: branching of gnome-vfs-extras
- Date: Thu, 14 Feb 2002 20:42:01 -0500 (EST)
On 14 Feb 2002, Bastien Nocera wrote:
> Hi,
>
> On Thu, 2002-02-14 at 20:42, Alex Larsson wrote:
> > On 14 Feb 2002, Bastien Nocera wrote:
> >
> > > Hi Alex,
> > >
> > > Could you branch gnome-vfs-extras for Gnome2.0 ? I'm interested in
> > > starting porting to 2.0.
> >
> > Sure. It shouldn't be hard.
> >
> > Can you do it even?
>
> I've branched the gnome-vfs-extras module to "gnome-2", and did a first
> shot at the port. I have two FIXME items, that break permissions. Can
> you take a quick look at them Alex ?
> The rio500 module won't work, btw.
You mean the
//FIXME this is broken, but otherwise it crashes
if (info->mode & aDIR)
file_info->type = GNOME_VFS_FILE_TYPE_DIRECTORY;
else
file_info->type = GNOME_VFS_FILE_TYPE_REGULAR;
file_info->valid_fields |=
GNOME_VFS_FILE_INFO_FIELDS_TYPE;
//FIXME same here
if (info->mode & aDIR)
file_info->type = GNOME_VFS_FILE_TYPE_DIRECTORY;
else
file_info->type = GNOME_VFS_FILE_TYPE_REGULAR;
file_info->valid_fields |=
GNOME_VFS_FILE_INFO_FIELDS_MIME_TYPE;
In what way is it broken? And why is that code repeated twice?
Hmm... The second one seems to set file_info->type, but then claim the
mime type is valid. That seems bogus.
Hrmm... The old code looks slighly broken in this respect too.
/ Alex
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]