Re: [Deskbar] [patch] crash in history handler

["Mikkel Kamstrup Erlandsen" <mikkel kamstrup gmail com>]

2007/9/11, Sebastian Pölsterl <marduk k-d-w org>:

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Mikkel Kamstrup Erlandsen schrieb:
> Without this patch the history module consistently crashes with :
>
> Traceback (most recent call last):
>   File
> "/home/mikkel/Projects/deskbar-applet/deskbar/ui/CuemiacWindowView.py",
> line 216, in append_matches
>     self.treeview_model.append (matches, self.entry.get_text())
>   File
> "/home/mikkel/Projects/deskbar-applet/deskbar/ui/cuemiac/CuemiacModel.py",
> line 105, in append
>     self.__append_match(hit, query_string)
>   File
> "/home/mikkel/Projects/deskbar-applet/deskbar/ui/cuemiac/CuemiacModel.py",
> line 91, in __append_match
>     if not self.__match_hashes.has_key(match_obj.get_hash()):
>   File
> "/home/mikkel/Projects/deskbar-applet/deskbar/handlers/history.py", line
> 19, in get_hash
>     return "history_"+self._action.get_hash()
> TypeError: cannot concatenate 'str' and 'NoneType' objects
>
Arg, one day too late. Now you have to request a Hard Code freeze break.
Could you do that, because it's your patch anyway?

Ooops, sorry about that :-)
I don't know if it is the right fix though. If you think it is OK, I can try to get it acked. So, is it ok?

Cheers,
Mikkel