[Deskbar] [patch] crash in history handler



Without this patch the history module consistently crashes with :

Traceback (most recent call last):
  File "/home/mikkel/Projects/deskbar-applet/deskbar/ui/CuemiacWindowView.py", line 216, in append_matches
    self.treeview_model.append (matches, self.entry.get_text())
  File "/home/mikkel/Projects/deskbar-applet/deskbar/ui/cuemiac/CuemiacModel.py", line 105, in append
    self.__append_match(hit, query_string)
  File "/home/mikkel/Projects/deskbar-applet/deskbar/ui/cuemiac/CuemiacModel.py", line 91, in __append_match
    if not self.__match_hashes.has_key(match_obj.get_hash()):
  File "/home/mikkel/Projects/deskbar-applet/deskbar/handlers/history.py", line 19, in get_hash
    return "history_"+self._action.get_hash()
TypeError: cannot concatenate 'str' and 'NoneType' objects

Cheers,
Mikkel
Index: deskbar/handlers/history.py
===================================================================
--- deskbar/handlers/history.py	(revision 1659)
+++ deskbar/handlers/history.py	(working copy)
@@ -16,7 +16,7 @@
         self._action = action
    
     def get_hash(self, text=None):
-        return "history_"+self._action.get_hash()
+        return "history_"+str(self._action.get_hash())
     
     def get_icon(self):
         return self._action.get_pixbuf()
Index: deskbar/deskbar-applet.py
===================================================================
--- deskbar/deskbar-applet.py	(revision 1659)
+++ deskbar/deskbar-applet.py	(working copy)
@@ -96,4 +96,4 @@
             gnomeapplet.Applet.__gtype__,
             deskbar.defs.PACKAGE,
             deskbar.defs.VERSION,
-            applet_factory)
\ No newline at end of file
+            applet_factory)
Index: deskbar/ui/cuemiac/Makefile.am
===================================================================
--- deskbar/ui/cuemiac/Makefile.am	(revision 1659)
+++ deskbar/ui/cuemiac/Makefile.am	(working copy)
@@ -7,4 +7,4 @@
 	CuemiacHistory.py \
 	CuemiacItems.py \
 	CuemiacModel.py \
-	CuemiacTreeView.py
\ No newline at end of file
+	CuemiacTreeView.py


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]