Re: mozilla extension suggestion

[Tom von Schwerdtner <tomvons gmail com>]

On Thu, 27 Jan 2005 12:32:24 -0500, Joe Shaw <joeshaw novell com> wrote:
> Hey Tom,
> 
> On Wed, 2005-01-26 at 23:53 -0500, Tom von Schwerdtner wrote:
> > I've gotten some reports of this patch not applying correctly, however
> > this one (same thing elsewhere) seems to work fine:
> >
> > http://tvon.etria.com/images/mozilla-extension.patch.gz
> 
> I don't feel the least bit qualified to review these, but they look okay
> from a cursory look.  Alex Graveley wrote the Mozilla extension
> originally; maybe he can look them over?  If you feel confident about
> it, I have no problem with the patch being checked in.

I'm about as confident about it as I can be.  I put it through
whatever user testing I could think of and it seems okay.  It
certainly won't kill any kittens or anything.

I'd suggest committing the latest iteration of the patch and letting
any bug reports roll in.  If you want you can add me to bugzilla and
assign any reports about it to me though I cannot guarantee that I'll
be able to respond quickly (I sort of stole time to do what I've done
so far), but I will try to fix any bugs that get filed.

It does have some noteworthy limitiations:

1) The 'domain' string for filtering has to be a FQDN.  In other
words, 'www.google.com' and 'google.com' are not the same thing.  I
think this is good (I don't want to filter groups.google.com but I do
want to filter google.com) but it could be a little more explicit in
the UI.
2) protocol's entered in the domain textbox will not be stripped out
and won't match anything (eg, 'http://www.google.com/' won't filter
the 'www.google.com' domain).
3) Hitting 'return' in the domain textbox will not invoke the 'add
filter' method (you have to click the 'add' button).
4) The UI still isn't very HIGly.

I don't think any of these are usability showstoppers, but it would be
nice if the issues were resolved.

-Tom


-- 
Tom von Schwerdtner
Etria, LLP :: http://etria.com/
Baltimore, MD