Re: Google Contacts Problem

["John Stowers" <john stowers gmail com>]

On Thu, Sep 4, 2008 at 2:11 PM, John Carr <john carr unrouted co uk> wrote:

Hi Roumano

Thanks very much for the feedback. I've attached a corrected version
of the patch (note it includes add-vcf-extension.diff as well so be
sure to revert before trying it out).

John: Do you have any thoughts on the add-vcf-extensions part of this
patch? Will it break things in ways i can't imagine?

I dont think it will break anything.

Personally I would have made the tempfile, and then renamed it/changed its extension in the converter instead of the current approach, but in any case, I would like a test to be added to the TestCoreConverter that exercised this.

Also, my preference is to just use suffix from kwargs. 

suffix = kwargs.get('suffix', None)

John

John

On Wed, Sep 3, 2008 at 11:21 AM, Roumano :) <roumano gmail com> wrote:
> Hello,
> The add-vcf-extension.diff works great for me.
>
> The first is not working, after patching lunching conduit :
> [Module              ][WARNING] Error loading the file:
> /work/perso/conduit/1716/conduit/modules/GoogleModule/GoogleModule.py
> Traceback (most recent call last):
>  File "/work/perso/conduit/1716/conduit/Module.py", line 173, in
> _load_modules_in_file
>    mod = self._import_file(filename)
>  File "/work/perso/conduit/1716/conduit/Module.py", line 154, in _import_file
>    mods = pydoc.importfile (filename)
>  File "/usr/lib/python2.5/pydoc.py", line 259, in importfile
>    raise ErrorDuringImport(path, sys.exc_info())
> ErrorDuringImport: problem in
> /work/perso/conduit/1716/conduit/modules/GoogleModule/GoogleModule.py
> - <type 'exceptions.SyntaxError'>: invalid syntax (GoogleModule.py,
> line 945)
>  (Module.py:201)
>
> Regards.
>
>