[gnome-software: 2/4] gs-plugin-job: Drop unused category property

[Milan Crha <mcrha src gnome org>]

commit c3c47ec0a3daf297942c5762c6398e1fe8f89798
Author: Philip Withnall <pwithnall endlessos org>
Date:   Tue May 24 18:32:54 2022 +0100

    gs-plugin-job: Drop unused category property
    
    It’s no longer used since moving category queries to `GsAppQuery`.
    
    Signed-off-by: Philip Withnall <pwithnall endlessos org>
    
    Helps: #1472

 lib/gs-plugin-job-private.h |  1 -
 lib/gs-plugin-job.c         | 41 -----------------------------------------
 lib/gs-plugin-job.h         |  3 ---
 3 files changed, 45 deletions(-)
---
diff --git a/lib/gs-plugin-job-private.h b/lib/gs-plugin-job-private.h
index ed1e50d63..0d0e0af50 100644
--- a/lib/gs-plugin-job-private.h
+++ b/lib/gs-plugin-job-private.h
@@ -35,7 +35,6 @@ GsApp                 *gs_plugin_job_get_app                  (GsPluginJob    *self);
 GsAppList              *gs_plugin_job_get_list                 (GsPluginJob    *self);
 GFile                  *gs_plugin_job_get_file                 (GsPluginJob    *self);
 GsPlugin               *gs_plugin_job_get_plugin               (GsPluginJob    *self);
-GsCategory             *gs_plugin_job_get_category             (GsPluginJob    *self);
 gchar                  *gs_plugin_job_to_string                (GsPluginJob    *self);
 void                    gs_plugin_job_set_action               (GsPluginJob    *self,
                                                                 GsPluginAction  action);
diff --git a/lib/gs-plugin-job.c b/lib/gs-plugin-job.c
index f0b4cbede..6bcf56697 100644
--- a/lib/gs-plugin-job.c
+++ b/lib/gs-plugin-job.c
@@ -32,7 +32,6 @@ typedef struct
        GsApp                   *app;
        GsAppList               *list;
        GFile                   *file;
-       GsCategory              *category;
        gint64                   time_created;
 } GsPluginJobPrivate;
 
@@ -47,7 +46,6 @@ enum {
        PROP_APP,
        PROP_LIST,
        PROP_FILE,
-       PROP_CATEGORY,
        PROP_MAX_RESULTS,
        PROP_TIMEOUT,
        PROP_PROPAGATE_ERROR,
@@ -94,17 +92,6 @@ gs_plugin_job_to_string (GsPluginJob *self)
                g_string_append_printf (str, " with search=%s",
                                        priv->search);
        }
-       if (priv->category != NULL) {
-               GsCategory *parent = gs_category_get_parent (priv->category);
-               if (parent != NULL) {
-                       g_string_append_printf (str, " with category=%s/%s",
-                                               gs_category_get_id (parent),
-                                               gs_category_get_id (priv->category));
-               } else {
-                       g_string_append_printf (str, " with category=%s",
-                                               gs_category_get_id (priv->category));
-               }
-       }
        if (priv->file != NULL) {
                g_autofree gchar *path = g_file_get_path (priv->file);
                g_string_append_printf (str, " with file=%s", path);
@@ -385,22 +372,6 @@ gs_plugin_job_get_plugin (GsPluginJob *self)
        return priv->plugin;
 }
 
-void
-gs_plugin_job_set_category (GsPluginJob *self, GsCategory *category)
-{
-       GsPluginJobPrivate *priv = gs_plugin_job_get_instance_private (self);
-       g_return_if_fail (GS_IS_PLUGIN_JOB (self));
-       g_set_object (&priv->category, category);
-}
-
-GsCategory *
-gs_plugin_job_get_category (GsPluginJob *self)
-{
-       GsPluginJobPrivate *priv = gs_plugin_job_get_instance_private (self);
-       g_return_val_if_fail (GS_IS_PLUGIN_JOB (self), NULL);
-       return priv->category;
-}
-
 static void
 gs_plugin_job_get_property (GObject *obj, guint prop_id, GValue *value, GParamSpec *pspec)
 {
@@ -435,9 +406,6 @@ gs_plugin_job_get_property (GObject *obj, guint prop_id, GValue *value, GParamSp
        case PROP_FILE:
                g_value_set_object (value, priv->file);
                break;
-       case PROP_CATEGORY:
-               g_value_set_object (value, priv->category);
-               break;
        case PROP_MAX_RESULTS:
                g_value_set_uint (value, priv->max_results);
                break;
@@ -486,9 +454,6 @@ gs_plugin_job_set_property (GObject *obj, guint prop_id, const GValue *value, GP
        case PROP_FILE:
                gs_plugin_job_set_file (self, g_value_get_object (value));
                break;
-       case PROP_CATEGORY:
-               gs_plugin_job_set_category (self, g_value_get_object (value));
-               break;
        case PROP_MAX_RESULTS:
                gs_plugin_job_set_max_results (self, g_value_get_uint (value));
                break;
@@ -515,7 +480,6 @@ gs_plugin_job_finalize (GObject *obj)
        g_clear_object (&priv->list);
        g_clear_object (&priv->file);
        g_clear_object (&priv->plugin);
-       g_clear_object (&priv->category);
 
        G_OBJECT_CLASS (gs_plugin_job_parent_class)->finalize (obj);
 }
@@ -575,11 +539,6 @@ gs_plugin_job_class_init (GsPluginJobClass *klass)
                                     G_PARAM_READWRITE);
        g_object_class_install_property (object_class, PROP_FILE, pspec);
 
-       pspec = g_param_spec_object ("category", NULL, NULL,
-                                    GS_TYPE_CATEGORY,
-                                    G_PARAM_READWRITE);
-       g_object_class_install_property (object_class, PROP_CATEGORY, pspec);
-
        pspec = g_param_spec_uint ("max-results", NULL, NULL,
                                   0, G_MAXUINT, 0,
                                   G_PARAM_READWRITE);
diff --git a/lib/gs-plugin-job.h b/lib/gs-plugin-job.h
index f6959de93..e7ebd1374 100644
--- a/lib/gs-plugin-job.h
+++ b/lib/gs-plugin-job.h
@@ -11,7 +11,6 @@
 #include <glib-object.h>
 
 #include "gs-app-list.h"
-#include "gs-category.h"
 #include "gs-plugin-types.h"
 
 G_BEGIN_DECLS
@@ -63,8 +62,6 @@ void           gs_plugin_job_set_file                 (GsPluginJob    *self,
                                                         GFile          *file);
 void            gs_plugin_job_set_plugin               (GsPluginJob    *self,
                                                         GsPlugin       *plugin);
-void            gs_plugin_job_set_category             (GsPluginJob    *self,
-                                                        GsCategory     *category);
 
 #define                 gs_plugin_job_newv(a,...)              
GS_PLUGIN_JOB(g_object_new(GS_TYPE_PLUGIN_JOB, "action", a, __VA_ARGS__))