[gnome-software: 1/4] gs-plugin-job: Drop unused review property
- From: Milan Crha <mcrha src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-software: 1/4] gs-plugin-job: Drop unused review property
- Date: Wed, 25 May 2022 06:31:34 +0000 (UTC)
commit b51a61295318514fee801854323859f94a41bdb4
Author: Philip Withnall <pwithnall endlessos org>
Date: Tue May 24 18:31:51 2022 +0100
gs-plugin-job: Drop unused review property
It’s no longer used.
Signed-off-by: Philip Withnall <pwithnall endlessos org>
Helps: #1472
lib/gs-plugin-job-private.h | 1 -
lib/gs-plugin-job.c | 34 ----------------------------------
lib/gs-plugin-job.h | 2 --
3 files changed, 37 deletions(-)
---
diff --git a/lib/gs-plugin-job-private.h b/lib/gs-plugin-job-private.h
index f75dda95f..ed1e50d63 100644
--- a/lib/gs-plugin-job-private.h
+++ b/lib/gs-plugin-job-private.h
@@ -36,7 +36,6 @@ GsAppList *gs_plugin_job_get_list (GsPluginJob *self);
GFile *gs_plugin_job_get_file (GsPluginJob *self);
GsPlugin *gs_plugin_job_get_plugin (GsPluginJob *self);
GsCategory *gs_plugin_job_get_category (GsPluginJob *self);
-AsReview *gs_plugin_job_get_review (GsPluginJob *self);
gchar *gs_plugin_job_to_string (GsPluginJob *self);
void gs_plugin_job_set_action (GsPluginJob *self,
GsPluginAction action);
diff --git a/lib/gs-plugin-job.c b/lib/gs-plugin-job.c
index 163ce2b1d..f0b4cbede 100644
--- a/lib/gs-plugin-job.c
+++ b/lib/gs-plugin-job.c
@@ -33,7 +33,6 @@ typedef struct
GsAppList *list;
GFile *file;
GsCategory *category;
- AsReview *review;
gint64 time_created;
} GsPluginJobPrivate;
@@ -49,7 +48,6 @@ enum {
PROP_LIST,
PROP_FILE,
PROP_CATEGORY,
- PROP_REVIEW,
PROP_MAX_RESULTS,
PROP_TIMEOUT,
PROP_PROPAGATE_ERROR,
@@ -107,10 +105,6 @@ gs_plugin_job_to_string (GsPluginJob *self)
gs_category_get_id (priv->category));
}
}
- if (priv->review != NULL) {
- g_string_append_printf (str, " with review=%s",
- as_review_get_id (priv->review));
- }
if (priv->file != NULL) {
g_autofree gchar *path = g_file_get_path (priv->file);
g_string_append_printf (str, " with file=%s", path);
@@ -407,22 +401,6 @@ gs_plugin_job_get_category (GsPluginJob *self)
return priv->category;
}
-void
-gs_plugin_job_set_review (GsPluginJob *self, AsReview *review)
-{
- GsPluginJobPrivate *priv = gs_plugin_job_get_instance_private (self);
- g_return_if_fail (GS_IS_PLUGIN_JOB (self));
- g_set_object (&priv->review, review);
-}
-
-AsReview *
-gs_plugin_job_get_review (GsPluginJob *self)
-{
- GsPluginJobPrivate *priv = gs_plugin_job_get_instance_private (self);
- g_return_val_if_fail (GS_IS_PLUGIN_JOB (self), NULL);
- return priv->review;
-}
-
static void
gs_plugin_job_get_property (GObject *obj, guint prop_id, GValue *value, GParamSpec *pspec)
{
@@ -460,9 +438,6 @@ gs_plugin_job_get_property (GObject *obj, guint prop_id, GValue *value, GParamSp
case PROP_CATEGORY:
g_value_set_object (value, priv->category);
break;
- case PROP_REVIEW:
- g_value_set_object (value, priv->review);
- break;
case PROP_MAX_RESULTS:
g_value_set_uint (value, priv->max_results);
break;
@@ -514,9 +489,6 @@ gs_plugin_job_set_property (GObject *obj, guint prop_id, const GValue *value, GP
case PROP_CATEGORY:
gs_plugin_job_set_category (self, g_value_get_object (value));
break;
- case PROP_REVIEW:
- gs_plugin_job_set_review (self, g_value_get_object (value));
- break;
case PROP_MAX_RESULTS:
gs_plugin_job_set_max_results (self, g_value_get_uint (value));
break;
@@ -544,7 +516,6 @@ gs_plugin_job_finalize (GObject *obj)
g_clear_object (&priv->file);
g_clear_object (&priv->plugin);
g_clear_object (&priv->category);
- g_clear_object (&priv->review);
G_OBJECT_CLASS (gs_plugin_job_parent_class)->finalize (obj);
}
@@ -609,11 +580,6 @@ gs_plugin_job_class_init (GsPluginJobClass *klass)
G_PARAM_READWRITE);
g_object_class_install_property (object_class, PROP_CATEGORY, pspec);
- pspec = g_param_spec_object ("review", NULL, NULL,
- AS_TYPE_REVIEW,
- G_PARAM_READWRITE);
- g_object_class_install_property (object_class, PROP_REVIEW, pspec);
-
pspec = g_param_spec_uint ("max-results", NULL, NULL,
0, G_MAXUINT, 0,
G_PARAM_READWRITE);
diff --git a/lib/gs-plugin-job.h b/lib/gs-plugin-job.h
index bfbb37a12..f6959de93 100644
--- a/lib/gs-plugin-job.h
+++ b/lib/gs-plugin-job.h
@@ -65,8 +65,6 @@ void gs_plugin_job_set_plugin (GsPluginJob *self,
GsPlugin *plugin);
void gs_plugin_job_set_category (GsPluginJob *self,
GsCategory *category);
-void gs_plugin_job_set_review (GsPluginJob *self,
- AsReview *review);
#define gs_plugin_job_newv(a,...)
GS_PLUGIN_JOB(g_object_new(GS_TYPE_PLUGIN_JOB, "action", a, __VA_ARGS__))
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]