[gnome-software/1409-add-available-for-fedora-section-to-the-explore-page] Apply 3 suggestion(s) to 2 file(s)
- From: Milan Crha <mcrha src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-software/1409-add-available-for-fedora-section-to-the-explore-page] Apply 3 suggestion(s) to 2 file(s)
- Date: Wed, 25 May 2022 06:11:14 +0000 (UTC)
commit 0b232fdd835b3562a7b84a6565830bed4b5218f6
Author: Philip Withnall <philip tecnocode co uk>
Date: Wed May 25 06:11:13 2022 +0000
Apply 3 suggestion(s) to 2 file(s)
doc/vendor-customisation.md | 29 ++++++++++++++---------------
src/gs-overview-page.c | 2 +-
2 files changed, 15 insertions(+), 16 deletions(-)
---
diff --git a/doc/vendor-customisation.md b/doc/vendor-customisation.md
index eac2845c2..1404eeeae 100644
--- a/doc/vendor-customisation.md
+++ b/doc/vendor-customisation.md
@@ -185,27 +185,26 @@ Deployment Featured Apps
------------------------
Deployments can feature their own applications, which will be shown in the Explore
-page in its own section. To have the section shown two files needs to be provided.
+page in its own section. To have the section shown, two files need to be provided. The number of
deployment-featured apps is limited in the UI, and if not enough deployment-featured apps are found, then the
section will not be shown at all.
The first file is `org.gnome.Software.DeploymentFeatured.xml`, which works similarly
-as the `org.gnome.Software.Featured.xml` and should be saved beside it, it only sets
-`GnomeSoftware::DeploymentFeatured` key for the apps. The value of this key is
-a string containing the deployment name. There is a limit of the found featured
-apps. The section is not shown when no enough apps are found.
-
-The second file is `deployment-featured.ini` file, which contains the label and
-the selector for the section. The label is a localized key, containing the label
-text for the section. The selector defines which apps should be picked. It is
+to `org.gnome.Software.Featured.xml` and should be saved beside it in an appstream directory. It sets the
+`GnomeSoftware::DeploymentFeatured` key on apps which should be featured for this distribution or
deployment. The value of this key is
+a string containing the deployment name as an identifier.
+
+The second file is `deployment-featured.ini`, which contains a human-readable title and
+the selector for the section. The title is a localized key, and is used to set the heading for the section
on the Explore page. The selector defines which apps should be picked. It is
a semicolon-separated list of `GnomeSoftware::DeploymentFeatured` key values, thus
-the deployment can feature apps from more vendors. The `deployment-featured.ini`
+the deployment can feature apps from zero or more vendors.
+
+The `deployment-featured.ini` file
should be saved in one of the `sysconfdir`, system config dirs or system data
-dirs, which are checked, in this order, for existence of the `gnome-software/deployment-featured.ini`
-file and the first directory containing it will be used. The relevant file names
-contain `/etc/xdg/gnome-software/deployment-featured.ini`,
+dirs. They are checked, in that order, for existence of the `gnome-software/deployment-featured.ini`
+file. The first directory containing it will be used. The relevant file names
+are `/etc/xdg/gnome-software/deployment-featured.ini`,
`/usr/local/share/gnome-software/deployment-featured.ini` and
`/usr/share/gnome-software/deployment-featured.ini`.
-Any changes of these files, including their adding/remove, require restart of
-the gnome-software process.
+Any changes to these files, including adding or removing them, will only be noticed when gnome-software is
restarted.
Example files can be found in the `contrib/` directory.
diff --git a/src/gs-overview-page.c b/src/gs-overview-page.c
index 238c9c601..4231430dc 100644
--- a/src/gs-overview-page.c
+++ b/src/gs-overview-page.c
@@ -350,7 +350,7 @@ gs_overview_page_get_deployment_featured_cb (GObject *source_object,
gs_widget_remove_all (self->box_deployment_featured, (GsRemoveFunc) gtk_flow_box_remove);
- for (i = 0; i < gs_app_list_length (list) && i < N_TILES; i++) {
+ for (i = 0; i < gs_app_list_length (list); i++) {
app = gs_app_list_index (list, i);
tile = gs_summary_tile_new (app);
g_signal_connect (tile, "clicked",
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]