[gimp] Fix: unable to open online help



commit cb47a720551a4ff15c7579c654fde570beb91859
Author: Jacob Boerema <jgboerema gmail com>
Date:   Wed Mar 23 15:40:28 2022 -0400

    Fix: unable to open online help
    
    Recently it was not possibly in master to open online help (F1).
    
    This is also mentioned in issue #7915. However, on macOS there are likely
    also other problems, which is why I'm hesitant to close that issue with
    this fix.
    
    (help.exe:57964): LibGimpBase-CRITICAL **: 15:24:38.792:
    gimp_value_array_index: assertion 'index < value_array->n_values' failed
    
    (help.exe:57964): GLib-GObject-CRITICAL **: 15:24:38.792: g_value_get_boxed:
    assertion 'G_VALUE_HOLDS_BOXED (value)' failed
    
    This was most likely caused by 8eb7f6df9e903b6b544f4d949e97c67f915f8fe7
    
    Changing this to use args 0 and 1 instead of 1 and 2 fixes the problem.

 plug-ins/help/help.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/plug-ins/help/help.c b/plug-ins/help/help.c
index 285afe1d42..6404362eca 100644
--- a/plug-ins/help/help.c
+++ b/plug-ins/help/help.c
@@ -158,8 +158,8 @@ help_run (GimpProcedure        *procedure,
 
   INIT_I18N ();
 
-  if (! gimp_help_init (GIMP_VALUES_GET_STRV (args, 1),
-                        GIMP_VALUES_GET_STRV (args, 2)))
+  if (! gimp_help_init (GIMP_VALUES_GET_STRV (args, 0),
+                        GIMP_VALUES_GET_STRV (args, 1)))
     {
       status = GIMP_PDB_CALLING_ERROR;
     }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]