[goffice] xy: fix crash



commit a4ba1a39d2317d4feb1b4aac78aa71b32732ba51
Author: Morten Welinder <terra gnome org>
Date:   Mon Aug 29 19:24:41 2022 -0400

    xy: fix crash

 ChangeLog                        | 5 +++++
 NEWS                             | 1 +
 plugins/plot_xy/gog-xy-dropbar.c | 2 +-
 3 files changed, 7 insertions(+), 1 deletion(-)
---
diff --git a/ChangeLog b/ChangeLog
index e86f87c1..fb2e3062 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2022-08-29  Morten Welinder  <terra gnome org>
+
+       * plugins/plot_xy/gog-xy-dropbar.c (gog_xy_dropbar_view_render):
+       Fix typo.  Fixes crash in Gnumeric #667.
+
 2022-04-18  Morten Welinder <terra gnome org>
 
        * configure.ac: Post-release bump.
diff --git a/NEWS b/NEWS
index d9f66ccf..3c5aed1a 100644
--- a/NEWS
+++ b/NEWS
@@ -3,6 +3,7 @@ goffice 0.10.53:
 Morten:
        * Fix problem rendering "...E-xx" numbers.  [#60]
        * Hack around introspection issue.  [Part of #59]
+       * Fix crash in plot [Gnumeric #667]
 
 --------------------------------------------------------------------------
 goffice 0.10.52:
diff --git a/plugins/plot_xy/gog-xy-dropbar.c b/plugins/plot_xy/gog-xy-dropbar.c
index ecf11514..d56b7981 100644
--- a/plugins/plot_xy/gog-xy-dropbar.c
+++ b/plugins/plot_xy/gog-xy-dropbar.c
@@ -444,7 +444,7 @@ gog_xy_dropbar_view_render (GogView *view, GogViewAllocation const *bbox)
                neg_style->fill.pattern.back ^= 0xffffff00;
                neg_style->fill.pattern.fore ^= 0xffffff00;
                pos_vals = go_data_get_values (series->values[0].data);
-               n = go_data_get_vector_size (series->values[1].data);
+               n = go_data_get_vector_size (series->values[0].data);
                start_vals = go_data_get_values (series->values[1].data);
                tmp = go_data_get_vector_size (series->values[1].data);
                if (n > tmp)


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]