[gnome-software/1878-failure-to-get-updates-in-one-plugin-skips-other-plugins] snap: Ignore errors when getting updates
- From: Milan Crha <mcrha src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-software/1878-failure-to-get-updates-in-one-plugin-skips-other-plugins] snap: Ignore errors when getting updates
- Date: Fri, 26 Aug 2022 14:25:58 +0000 (UTC)
commit 1a45298e105a0c1129fb7568d2954bb6b3ad9fd1
Author: Milan Crha <mcrha redhat com>
Date: Fri Aug 26 15:30:59 2022 +0200
snap: Ignore errors when getting updates
Do not pass errors to the caller, only print them into the verbose log,
to not block updates from the other plugins.
Closes https://gitlab.gnome.org/GNOME/gnome-software/-/issues/1878
plugins/snap/gs-plugin-snap.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
---
diff --git a/plugins/snap/gs-plugin-snap.c b/plugins/snap/gs-plugin-snap.c
index d7d4162b3..2756549cf 100644
--- a/plugins/snap/gs-plugin-snap.c
+++ b/plugins/snap/gs-plugin-snap.c
@@ -1829,9 +1829,11 @@ gs_plugin_add_updates (GsPlugin *plugin,
gboolean interactive = gs_plugin_has_flags (plugin, GS_PLUGIN_FLAGS_INTERACTIVE);
g_autoptr(GError) error_local = NULL;
- client = get_client (self, interactive, error);
- if (client == NULL)
- return FALSE;
+ client = get_client (self, interactive, &error_local);
+ if (client == NULL) {
+ g_debug ("Failed to get client to get updates: %s", error_local->message);
+ return TRUE;
+ }
/* Get the list of refreshable snaps */
apps = snapd_client_find_refreshable_sync (client, cancellable, &error_local);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]