[gnome-software/1878-failure-to-get-updates-in-one-plugin-skips-other-plugins] fwupd: Ignore errors when getting updates
- From: Milan Crha <mcrha src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-software/1878-failure-to-get-updates-in-one-plugin-skips-other-plugins] fwupd: Ignore errors when getting updates
- Date: Fri, 26 Aug 2022 14:25:58 +0000 (UTC)
commit 45c116de8e24fff9c6732d5176ad78dbb0e3e713
Author: Milan Crha <mcrha redhat com>
Date: Fri Aug 26 15:28:22 2022 +0200
fwupd: Ignore errors when getting updates
Do not pass errors to the caller, only print them into the verbose log,
to not block updates from the other plugins.
Helps https://gitlab.gnome.org/GNOME/gnome-software/-/issues/1878
plugins/fwupd/gs-plugin-fwupd.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
---
diff --git a/plugins/fwupd/gs-plugin-fwupd.c b/plugins/fwupd/gs-plugin-fwupd.c
index 37334bdc2..b5d99b7f1 100644
--- a/plugins/fwupd/gs-plugin-fwupd.c
+++ b/plugins/fwupd/gs-plugin-fwupd.c
@@ -609,9 +609,8 @@ gs_plugin_add_updates (GsPlugin *plugin,
g_debug ("no devices (%s)", error_local->message);
return TRUE;
}
- g_propagate_error (error, g_steal_pointer (&error_local));
- gs_plugin_fwupd_error_convert (error);
- return FALSE;
+ g_debug ("Failed to get devices: %s", error_local->message);
+ return TRUE;
}
for (guint i = 0; i < devices->len; i++) {
FwupdDevice *dev = g_ptr_array_index (devices, i);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]