[gnome-software/1878-failure-to-get-updates-in-one-plugin-skips-other-plugins] flatpak: Ignore errors when getting updates
- From: Milan Crha <mcrha src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-software/1878-failure-to-get-updates-in-one-plugin-skips-other-plugins] flatpak: Ignore errors when getting updates
- Date: Fri, 26 Aug 2022 14:25:58 +0000 (UTC)
commit 5f0ca7961dffe7a1abd34f8868c78122d34d04c3
Author: Milan Crha <mcrha redhat com>
Date: Fri Aug 26 15:26:39 2022 +0200
flatpak: Ignore errors when getting updates
Do not pass errors to the caller, only print them into the verbose log,
to not block updates from the other plugins.
Helps https://gitlab.gnome.org/GNOME/gnome-software/-/issues/1878
plugins/flatpak/gs-plugin-flatpak.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
---
diff --git a/plugins/flatpak/gs-plugin-flatpak.c b/plugins/flatpak/gs-plugin-flatpak.c
index 8510627fc..8bb612fcd 100644
--- a/plugins/flatpak/gs-plugin-flatpak.c
+++ b/plugins/flatpak/gs-plugin-flatpak.c
@@ -390,8 +390,9 @@ gs_plugin_add_updates (GsPlugin *plugin,
for (guint i = 0; i < self->installations->len; i++) {
GsFlatpak *flatpak = g_ptr_array_index (self->installations, i);
- if (!gs_flatpak_add_updates (flatpak, list, interactive, cancellable, error))
- return FALSE;
+ g_autoptr(GError) local_error = NULL;
+ if (!gs_flatpak_add_updates (flatpak, list, interactive, cancellable, &local_error))
+ g_debug ("Failed to get updates for '%s': %s", gs_flatpak_get_id (flatpak),
local_error->message);
}
gs_plugin_cache_lookup_by_state (plugin, list, GS_APP_STATE_INSTALLING);
return TRUE;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]