[nautilus] general: Add & fix tooltips to match HIG
- From: Corey Berla <coreyberla src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [nautilus] general: Add & fix tooltips to match HIG
- Date: Mon, 22 Aug 2022 21:54:24 +0000 (UTC)
commit 6836490485f5fa90c1c52e03d700d36d83917409
Author: Ronen Margolin <roni948576 gmail com>
Date: Mon Aug 22 21:54:23 2022 +0000
general: Add & fix tooltips to match HIG
Change tooltips for the toolbar as follows:
OLD:
Go back
Go forward
<Nothing for path bar locations>
<Nothing for the path bar menu>
Search
Show list
View options
<Nothing for the primary menu>
NEW:
Back
Forward
<Folder Name>
Current Folder Menu
Search
List View (or Grid View)
View Options
Main Menu
Fixes #2349.
src/nautilus-pathbar.c | 4 ++++
src/nautilus-view.c | 6 +++---
src/resources/ui/nautilus-history-controls.ui | 4 ++--
src/resources/ui/nautilus-toolbar.ui | 1 +
src/resources/ui/nautilus-view-controls.ui | 2 +-
5 files changed, 11 insertions(+), 6 deletions(-)
---
diff --git a/src/nautilus-pathbar.c b/src/nautilus-pathbar.c
index df95afdef..1890aa85e 100644
--- a/src/nautilus-pathbar.c
+++ b/src/nautilus-pathbar.c
@@ -266,6 +266,8 @@ nautilus_path_bar_init (NautilusPathBar *self)
gtk_image_new_from_icon_name ("view-more-symbolic"));
gtk_box_append (GTK_BOX (self), self->current_view_menu_button);
+ gtk_widget_set_tooltip_text (self->current_view_menu_button, _("Current Folder Menu"));
+
builder = gtk_builder_new ();
/* Add context menu for pathbar buttons */
@@ -754,6 +756,8 @@ nautilus_path_bar_update_button_appearance (ButtonData *button_data,
{
gtk_label_set_text (GTK_LABEL (button_data->label), dir_name);
+ gtk_widget_set_tooltip_text (button_data->button, dir_name);
+
if (current_dir)
{
/* We want to avoid ellipsizing the current directory name, but
diff --git a/src/nautilus-view.c b/src/nautilus-view.c
index 2463ba632..5ee424c07 100644
--- a/src/nautilus-view.c
+++ b/src/nautilus-view.c
@@ -147,15 +147,15 @@ nautilus_view_get_tooltip (guint view_id)
{
if (view_id == NAUTILUS_VIEW_GRID_ID)
{
- return _("Show grid");
+ return _("Grid View");
}
else if (view_id == NAUTILUS_VIEW_LIST_ID)
{
- return _("Show list");
+ return _("List View");
}
else if (view_id == NAUTILUS_VIEW_OTHER_LOCATIONS_ID)
{
- return _("Show List");
+ return _("List View");
}
else
{
diff --git a/src/resources/ui/nautilus-history-controls.ui b/src/resources/ui/nautilus-history-controls.ui
index b16ec45e8..0fd0ce5da 100644
--- a/src/resources/ui/nautilus-history-controls.ui
+++ b/src/resources/ui/nautilus-history-controls.ui
@@ -8,7 +8,7 @@
<property name="spacing">6</property>
<child>
<object class="GtkButton" id="back_button">
- <property name="tooltip_text" translatable="yes">Go back</property>
+ <property name="tooltip_text" translatable="yes">Back</property>
<property name="valign">center</property>
<property name="action_name">win.back</property>
<property name="icon_name">go-previous-symbolic</property>
@@ -16,7 +16,7 @@
</child>
<child>
<object class="GtkButton" id="forward_button">
- <property name="tooltip_text" translatable="yes">Go forward</property>
+ <property name="tooltip_text" translatable="yes">Forward</property>
<property name="valign">center</property>
<property name="action_name">win.forward</property>
<property name="icon_name">go-next-symbolic</property>
diff --git a/src/resources/ui/nautilus-toolbar.ui b/src/resources/ui/nautilus-toolbar.ui
index 480da491f..cdccb89fe 100644
--- a/src/resources/ui/nautilus-toolbar.ui
+++ b/src/resources/ui/nautilus-toolbar.ui
@@ -188,6 +188,7 @@
</child>
<child>
<object class="GtkMenuButton" id="app_button">
+ <property name="tooltip-text" translatable="yes">Main Menu</property>
<property name="halign">center</property>
<property name="valign">center</property>
<property name="icon_name">open-menu-symbolic</property>
diff --git a/src/resources/ui/nautilus-view-controls.ui b/src/resources/ui/nautilus-view-controls.ui
index 788b377d0..2231d66a0 100644
--- a/src/resources/ui/nautilus-view-controls.ui
+++ b/src/resources/ui/nautilus-view-controls.ui
@@ -23,7 +23,7 @@
<object class="AdwSplitButton" id="view_split_button">
<property name="halign">center</property>
<property name="valign">center</property>
- <property name="dropdown-tooltip" translatable="yes" comments="Translators: This is a noun, meaning
the options pertaining to the view.">View options</property>
+ <property name="dropdown-tooltip" translatable="yes" comments="Translators: This is a noun, meaning
the options pertaining to the view.">View Options</property>
<property name="action_name">slot.files-view-mode-toggle</property>
<property name="menu-model">view_menu</property>
<binding name="icon-name">
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]