[gnome-text-editor] sidebar: move docportal check into separate function

[Christian Hergert <chergert src gnome org>]

commit 12885e71ddc0350254b93ad5280053f1f1f8a8c3
Author: Christian Hergert <chergert redhat com>
Date:   Sun Aug 21 10:29:58 2022 -0700

    sidebar: move docportal check into separate function
    
    And check for G_OS_UNIX at the same time, since there is a chance that we
    have portals on non-Linux, but UNIX, soon enough.

 src/editor-sidebar-item.c | 44 ++++++++++++++++++++++++++------------------
 1 file changed, 26 insertions(+), 18 deletions(-)
---
diff --git a/src/editor-sidebar-item.c b/src/editor-sidebar-item.c
index 2b2cd30..b26bfb0 100644
--- a/src/editor-sidebar-item.c
+++ b/src/editor-sidebar-item.c
@@ -66,17 +66,34 @@ G_DEFINE_TYPE (EditorSidebarItem, editor_sidebar_item, G_TYPE_OBJECT)
 
 static GParamSpec *properties [N_PROPS];
 
+static gboolean
+file_is_from_document_portal (GFile *file)
+{
+#ifdef G_OS_UNIX
+  static char *docportal;
+
+  if G_UNLIKELY (docportal == NULL)
+    docportal = g_strdup_printf ("/run/user/%u/doc/", getuid ());
+
+  if (g_file_is_native (file))
+    {
+      const char *path = g_file_peek_path (file);
+
+      if (g_str_has_prefix (path, docportal))
+        return TRUE;
+    }
+#endif
+
+  return FALSE;
+}
+
 static void
 editor_sidebar_item_update_subtitle (EditorSidebarItem *self)
 {
-  static char *docportal = NULL;
   g_autoptr(GFile) dir = NULL;
 
   g_assert (EDITOR_IS_SIDEBAR_ITEM (self));
 
-  if (docportal == NULL)
-    docportal = g_strdup_printf ("/run/user/%u/doc/", getuid ());
-
   g_free (self->subtitle);
 
   if (self->file == NULL)
@@ -87,22 +104,13 @@ editor_sidebar_item_update_subtitle (EditorSidebarItem *self)
 
   /* Can happen, but implausible since someone tried to open "/" */
   if (!(dir = g_file_get_parent (self->file)))
-    {
-      self->subtitle = g_strdup ("");
-    }
+    self->subtitle = g_strdup ("");
+  else if (file_is_from_document_portal (dir))
+    self->subtitle = g_strdup (_("Document Portal"));
   else if (g_file_is_native (dir))
-    {
-      const char *peek = g_file_peek_path (dir);
-
-      if (g_str_has_prefix (peek, docportal))
-        self->subtitle = g_strdup (_("Document Portal"));
-      else
-        self->subtitle = _editor_path_collapse (g_file_peek_path (dir));
-    }
+    self->subtitle = _editor_path_collapse (g_file_peek_path (dir));
   else
-    {
-      self->subtitle = g_file_get_uri (dir);
-    }
+    self->subtitle = g_file_get_uri (dir);
 }
 
 static void