[gnome-software/wip/flatpak-error-reword] flatpak: Reword "failed to get permissions" error
- From: Milan Crha <mcrha src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-software/wip/flatpak-error-reword] flatpak: Reword "failed to get permissions" error
- Date: Thu, 14 Apr 2022 06:17:32 +0000 (UTC)
commit 47fd6414962c0487034ad3951363a6cd8de10721
Author: Milan Crha <mcrha redhat com>
Date: Thu Apr 14 08:13:28 2022 +0200
flatpak: Reword "failed to get permissions" error
This error message is misleading, it's unsure from it what claims it,
aka it can sound as a permission on the system level, which this means
to read permissions from the app metadata, thus rather mention that
in the message, to avoid confusion.
An example old error message:
failed to get search apps: failed to get permissions: No such ref 'XXX' in remote YYY
plugins/flatpak/gs-flatpak.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/plugins/flatpak/gs-flatpak.c b/plugins/flatpak/gs-flatpak.c
index 71d628035..91d6540c2 100644
--- a/plugins/flatpak/gs-flatpak.c
+++ b/plugins/flatpak/gs-flatpak.c
@@ -3261,7 +3261,7 @@ gs_flatpak_refine_app_unlocked (GsFlatpak *self,
gs_app_get_unique_id (app),
error_local->message);
} else {
- g_prefix_error (&error_local, "failed to get permissions: ");
+ g_prefix_error (&error_local, "failed to read permissions from app '%s'
metadata: ", gs_app_get_unique_id (app));
g_propagate_error (error, g_steal_pointer (&error_local));
return FALSE;
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]