[devdocsgjs/wip/andyholmes/upstream-merge] Dockerfile: remove the call to compile:assets temporarily



commit 4c711212a590c2235283542de6b80092718d3f01
Author: Andy Holmes <andrew g r holmes gmail com>
Date:   Fri Apr 8 15:02:23 2022 -0700

    Dockerfile: remove the call to compile:assets temporarily
    
    The call to `thor compile:assets` is only required in "production" mode,
    while we currently run the image in "development" mode.
    
    This causes two problems in practice:
    
     * It has the side-effect of removing the assets it needs to compile,
       which causes a run-time error when the "development" mode routines
       try to recompile the assets.
     * It results in the the `sprites:optimize_spritesheet` routine being
       run, which currently error out (for unknown reasons)

 Dockerfile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/Dockerfile b/Dockerfile
index 216386e4..87e4d5dc 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -117,6 +117,7 @@ RUN echo adw1 appindicator301 appstreamglib10 atk10 atspi20 cairo10 \
 # - Ruby 2.6.0 -> 2.7.5
 # - Copy from the build-stage image instead of the current dir
 # - Update bundler CLI usage
+# - Remove `thor compile:assets` until we run in production mode (TODO)
 # - The css and javascript docsets don't resolve and have been removed
 # - User permission fixes
 FROM docker.io/library/ruby:2.7.5-alpine
@@ -133,7 +134,6 @@ RUN apk --update add nodejs build-base libstdc++ gzip git zlib-dev libcurl && \
     bundle config set system 'true' && \
     bundle config set without 'test' && \
     bundle install && \
-    thor assets:compile && \
     apk del gzip build-base git zlib-dev && \
     rm -rf /var/cache/apk/* /tmp ~/.gem /root/.bundle/cache \
     /usr/local/bundle/cache /usr/lib/node_modules


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]