[calls] manager: Don't raise critical when origin id lookup fails



commit 69106910f8b4188cac0c1acb557c48d1184ab51d
Author: Evangelos Ribeiro Tzaras <devrtz fortysixandtwo eu>
Date:   Fri Apr 1 11:38:01 2022 +0200

    manager: Don't raise critical when origin id lookup fails
    
    We don't store origin ids yet
    because https://gitlab.gnome.org/GNOME/calls/-/merge_requests/505
    is pending on
    https://gitlab.gnome.org/GNOME/gom/-/merge_requests/12 and
    https://gitlab.gnome.org/GNOME/gom/-/merge_requests/13

 src/calls-manager.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
---
diff --git a/src/calls-manager.c b/src/calls-manager.c
index a84b49ee..dcdafb47 100644
--- a/src/calls-manager.c
+++ b/src/calls-manager.c
@@ -1092,7 +1092,10 @@ calls_manager_get_origin_by_id (CallsManager *self,
   uint n_origins;
 
   g_return_val_if_fail (CALLS_IS_MANAGER (self), NULL);
-  g_return_val_if_fail (origin_id && *origin_id, NULL);
+
+  /* TODO Turn this into a critical once https://gitlab.gnome.org/GNOME/calls/-/merge_requests/505 is in */
+  if (origin_id && *origin_id)
+    return NULL;
 
   n_origins = g_list_model_get_n_items (G_LIST_MODEL (self->origins));
   for (uint i = 0; i < n_origins; i++) {


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]