[gtk/more-glyph-drawing-fixes: 2/2] Revert "gsk: Stop enlarging text bounding boxes"
- From: Matthias Clasen <matthiasc src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gtk/more-glyph-drawing-fixes: 2/2] Revert "gsk: Stop enlarging text bounding boxes"
- Date: Fri, 17 Sep 2021 23:13:49 +0000 (UTC)
commit 7e4b2b971ff9b3d53c56fd96632e351cff8749bb
Author: Matthias Clasen <mclasen redhat com>
Date: Fri Sep 17 19:11:06 2021 -0400
Revert "gsk: Stop enlarging text bounding boxes"
This reverts commit 87af45403ace1047b91ddbab98d9d5a5e15b84eb.
I've found that this change is needed to ensure that the
bounding boxes of text nodes encompass all the glyphd drawing.
Without it, we overdraw the widget boundaries and cut off
glyphs.
gsk/gskrendernodeimpl.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
---
diff --git a/gsk/gskrendernodeimpl.c b/gsk/gskrendernodeimpl.c
index 18cbcd185a..fd2a9e5d44 100644
--- a/gsk/gskrendernodeimpl.c
+++ b/gsk/gskrendernodeimpl.c
@@ -4477,10 +4477,10 @@ gsk_text_node_new (PangoFont *font,
self->num_glyphs = n;
graphene_rect_init (&node->bounds,
- offset->x + ink_rect.x,
- offset->y + ink_rect.y,
- ink_rect.width,
- ink_rect.height);
+ offset->x + ink_rect.x - 1,
+ offset->y + ink_rect.y - 1,
+ ink_rect.width + 2,
+ ink_rect.height + 2);
return node;
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]