GNOME.org
 

[epiphany/wip/exalm/newtab-dark: 2/2] embed: Use New Tab title for overview as well


commit 73c4cd409343d678b39e318928ae524ab55750e1
Author: Alexander Mikhaylenko <alexm gnome org>
Date:   Wed Nov 24 13:42:20 2021 +0500

    embed: Use New Tab title for overview as well
    
    This indicates that it's a new tab better than Most Visited.

 embed/ephy-about-handler.c | 2 +-
 embed/ephy-embed-shell.c   | 3 +--
 embed/ephy-embed-utils.c   | 6 ++----
 embed/ephy-embed-utils.h   | 5 ++---
 4 files changed, 6 insertions(+), 10 deletions(-)
---
diff --git a/embed/ephy-about-handler.c b/embed/ephy-about-handler.c
index d502b845d..fde68cb1f 100644
--- a/embed/ephy-about-handler.c
+++ b/embed/ephy-about-handler.c
@@ -372,7 +372,7 @@ history_service_query_urls_cb (EphyHistoryService     *history,
                           "<body>\n",
                           lang, lang,
                           ((gtk_widget_get_default_direction () == GTK_TEXT_DIR_RTL) ? "rtl" : "ltr"),
-                          _(OVERVIEW_PAGE_TITLE));
+                          _(NEW_TAB_PAGE_TITLE));
   g_free (lang);
 
   list_length = g_list_length (urls);
diff --git a/embed/ephy-embed-shell.c b/embed/ephy-embed-shell.c
index abfa0d7d8..189370bd8 100644
--- a/embed/ephy-embed-shell.c
+++ b/embed/ephy-embed-shell.c
@@ -157,8 +157,7 @@ tabs_catalog_get_tabs_info (EphyTabsCatalog *catalog)
       title = ephy_embed_get_title (t->data);
 
       if (!g_strcmp0 (title, _(BLANK_PAGE_TITLE)) ||
-          !g_strcmp0 (title, _(NEW_TAB_PAGE_TITLE)) ||
-          !g_strcmp0 (title, _(OVERVIEW_PAGE_TITLE)))
+          !g_strcmp0 (title, _(NEW_TAB_PAGE_TITLE)))
         continue;
 
       url = ephy_web_view_get_display_address (ephy_embed_get_web_view (t->data));
diff --git a/embed/ephy-embed-utils.c b/embed/ephy-embed-utils.c
index 8621f136a..4abfe7bc9 100644
--- a/embed/ephy-embed-utils.c
+++ b/embed/ephy-embed-utils.c
@@ -415,10 +415,8 @@ ephy_embed_utils_get_title_from_address (const char *address)
     return g_strdup (address + 7);
 
   if (!strcmp (address, EPHY_ABOUT_SCHEME ":overview") ||
-      !strcmp (address, "about:overview"))
-    return g_strdup (_(OVERVIEW_PAGE_TITLE));
-
-  if (!strcmp (address, EPHY_ABOUT_SCHEME ":newtab") ||
+      !strcmp (address, EPHY_ABOUT_SCHEME ":newtab") ||
+      !strcmp (address, "about:overview") ||
       !strcmp (address, "about:newtab"))
     return g_strdup (_(NEW_TAB_PAGE_TITLE));
 
diff --git a/embed/ephy-embed-utils.h b/embed/ephy-embed-utils.h
index 613024956..cc41ce6ab 100644
--- a/embed/ephy-embed-utils.h
+++ b/embed/ephy-embed-utils.h
@@ -28,9 +28,8 @@
 
 G_BEGIN_DECLS
 
-#define BLANK_PAGE_TITLE N_("Blank page")      /* Title for the blank page */
-#define OVERVIEW_PAGE_TITLE N_("Most Visited") /* Title for the overview page */
-#define NEW_TAB_PAGE_TITLE N_("New Tab")       /* Title for the new tab page */
+#define BLANK_PAGE_TITLE N_("Blank page") /* Title for the blank page */
+#define NEW_TAB_PAGE_TITLE N_("New Tab")  /* Title for the new tab page */
 
 #define EPHY_GET_WEBKIT_WEB_VIEW_FROM_EMBED(embed) (WEBKIT_WEB_VIEW (ephy_embed_get_web_view (embed)))
 #define EPHY_GET_EMBED_FROM_EPHY_WEB_VIEW(view) (EPHY_EMBED (gtk_widget_get_parent (gtk_widget_get_parent 
((GTK_WIDGET (view))))))
[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]