[vte] emulation: ECMA modes should not be saved by DECSC

[Christian Persch <chpe src gnome org>]

commit db3c6253d7fa1645996a2abd9fd55df414ca4c2d
Author: Luis Javier Merino Morán <ninjalj gmail com>
Date:   Thu Nov 4 19:25:09 2021 +0100

    emulation: ECMA modes should not be saved by DECSC
    
    From esctest:
    DECRCTests.test_SaveRestoreCursor_InsertNotAffected
    DECSETTiteInhibitTests.test_SaveRestoreCursor_InsertNotAffected
    SCORCTests.test_SaveRestoreCursor_InsertNotAffected
    
    Fixes: https://gitlab.gnome.org/GNOME/vte/-/issues/2524

 src/vte.cc         | 4 ----
 src/vteinternal.hh | 1 -
 2 files changed, 5 deletions(-)
---
diff --git a/src/vte.cc b/src/vte.cc
index 742e73b8..46da6d4f 100644
--- a/src/vte.cc
+++ b/src/vte.cc
@@ -2836,8 +2836,6 @@ Terminal::restore_cursor(VteScreen *screen__)
         screen__->cursor.row = screen__->insert_delta + CLAMP(screen__->saved.cursor.row,
                                                               0, m_row_count - 1);
 
-        m_modes_ecma.set_modes(screen__->saved.modes_ecma);
-
         m_modes_private.set_DEC_REVERSE_IMAGE(screen__->saved.reverse_mode);
         m_modes_private.set_DEC_ORIGIN(screen__->saved.origin_mode);
 
@@ -2855,8 +2853,6 @@ Terminal::save_cursor(VteScreen *screen__)
         screen__->saved.cursor.col = screen__->cursor.col;
         screen__->saved.cursor.row = screen__->cursor.row - screen__->insert_delta;
 
-        screen__->saved.modes_ecma = m_modes_ecma.get_modes();
-
         screen__->saved.reverse_mode = m_modes_private.DEC_REVERSE_IMAGE();
         screen__->saved.origin_mode = m_modes_private.DEC_ORIGIN();
 
diff --git a/src/vteinternal.hh b/src/vteinternal.hh
index f3cfc750..b75582c4 100644
--- a/src/vteinternal.hh
+++ b/src/vteinternal.hh
@@ -140,7 +140,6 @@ public:
         /* Stuff saved along with the cursor */
         struct {
                 VteVisualPosition cursor;  /* onscreen coordinate, that is, relative to insert_delta */
-                uint8_t modes_ecma;
                 bool reverse_mode;
                 bool origin_mode;
                 VteCell defaults;