[gnome-software/1251-sources-for-an-app-randomly-appeared-in-header-on-updates-tab-gnome-40] gs-details-page: Refresh only when being selected

[Milan Crha <mcrha src gnome org>]

commit c7db2e69c2bedab2ba9ee754d0aeccbc1b2a82d4
Author: Milan Crha <mcrha redhat com>
Date:   Mon Jun 7 19:30:24 2021 +0200

    gs-details-page: Refresh only when being selected
    
    The second attempt, to not refresh the page when a reload is called,
    which can happen for example after Flatpak changes from the command
    line.
    
    Closes https://gitlab.gnome.org/GNOME/gnome-software/-/issues/1251

 src/gs-details-page.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)
---
diff --git a/src/gs-details-page.c b/src/gs-details-page.c
index 1b64d0009..b270e3afa 100644
--- a/src/gs-details-page.c
+++ b/src/gs-details-page.c
@@ -500,11 +500,12 @@ gs_details_page_switch_to_idle (gpointer user_data)
 {
        GsDetailsPage *self = GS_DETAILS_PAGE (user_data);
 
-       if (gs_shell_get_mode (self->shell) == GS_SHELL_MODE_DETAILS)
+       if (gs_shell_get_mode (self->shell) == GS_SHELL_MODE_DETAILS) {
                gs_page_switch_to (GS_PAGE (self), TRUE);
 
-       /* update widgets */
-       gs_details_page_refresh_all (self);
+               /* update widgets */
+               gs_details_page_refresh_all (self);
+       }
 
        g_object_unref (self);
        return G_SOURCE_REMOVE;
@@ -2227,7 +2228,7 @@ static void
 gs_details_page_reload (GsPage *page)
 {
        GsDetailsPage *self = GS_DETAILS_PAGE (page);
-       if (self->app != NULL)
+       if (self->app != NULL && gs_shell_get_mode (self->shell) == GS_SHELL_MODE_DETAILS)
                gs_details_page_load_stage1 (self);
 }