[orca] Web: Don't use character count to determine text-block-elementness
- From: Joanmarie Diggs <joanied src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [orca] Web: Don't use character count to determine text-block-elementness
- Date: Fri, 26 Feb 2021 12:05:08 +0000 (UTC)
commit 9f130e97fdd57a26a59289fb73b577df79565663
Author: Joanmarie Diggs <jdiggs igalia com>
Date: Fri Feb 26 13:00:59 2021 +0100
Web: Don't use character count to determine text-block-elementness
If an object is in the process of being destroyed, getting its
character count (without exception handling) can cause Orca to spit
up. While we could of course add that exception handling, the lack
of text content shouldn't cause us to deem an element not texty; it
is simply an empty text element. Therefore remove that character-
count check entirely.
src/orca/scripts/web/script_utilities.py | 2 --
1 file changed, 2 deletions(-)
---
diff --git a/src/orca/scripts/web/script_utilities.py b/src/orca/scripts/web/script_utilities.py
index 942ebd1b7..b2c9369b1 100644
--- a/src/orca/scripts/web/script_utilities.py
+++ b/src/orca/scripts/web/script_utilities.py
@@ -2217,8 +2217,6 @@ class Utilities(script_utilities.Utilities):
rv = False
elif not "Text" in interfaces:
rv = False
- elif not obj.queryText().characterCount:
- rv = False
elif state.contains(pyatspi.STATE_EDITABLE):
rv = False
elif self.isGridCell(obj):
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]