GNOME.org
 

[gnome-games] Make [GtkChild] fields unowned

commit c7fa21f0f97de1575d9f04be0573cde31c98aa85
Author: Alexander Mikhaylenko <alexm gnome org>
Date:   Sun Feb 21 03:03:24 2021 +0500

    Make [GtkChild] fields unowned
    
    See https://gitlab.gnome.org/GNOME/vala/-/issues/1121
    
    Fix compile-time warnings.

 .../src/nintendo-64-pak-controller.vala            |  6 +--
 .../nintendo-64/src/nintendo-64-pak-switcher.vala  |  4 +-
 src/gamepad/gamepad-mapper.vala                    |  2 +-
 src/gamepad/gamepad-tester.vala                    |  2 +-
 src/keyboard/keyboard-mapper.vala                  |  2 +-
 src/keyboard/keyboard-tester.vala                  |  2 +-
 src/preferences/preferences-page-controllers.vala  |  4 +-
 src/preferences/preferences-page-platforms.vala    |  2 +-
 src/preferences/preferences-page-video.vala        |  2 +-
 src/preferences/preferences-page.vala              |  6 +--
 src/preferences/preferences-subpage-gamepad.vala   | 12 ++---
 src/preferences/preferences-subpage-keyboard.vala  |  8 ++--
 src/preferences/preferences-window.vala            |  6 +--
 src/screen-layout/screen-layout-item.vala          |  6 +--
 src/screen-layout/screen-layout-switcher.vala      | 12 ++---
 src/ui/application-window.vala                     |  6 +--
 src/ui/collection-action-window.vala               | 24 +++++-----
 src/ui/collection-icon-view.vala                   |  4 +-
 src/ui/collection-thumbnail.vala                   |  6 +--
 src/ui/collection-view.vala                        | 52 +++++++++++-----------
 src/ui/collections-main-page.vala                  |  6 +--
 src/ui/collections-page.vala                       | 10 ++---
 src/ui/display-view.vala                           | 32 ++++++-------
 src/ui/error-info-bar.vala                         |  4 +-
 src/ui/fullscreen-box.vala                         |  2 +-
 src/ui/game-icon-view.vala                         |  4 +-
 src/ui/games-page.vala                             |  6 +--
 src/ui/input-mode-switcher.vala                    |  4 +-
 src/ui/media-menu-button.vala                      |  6 +--
 src/ui/platform-list-item.vala                     |  2 +-
 src/ui/platforms-page.vala                         |  8 ++--
 src/ui/search-bar.vala                             |  4 +-
 src/ui/selection-action-bar.vala                   |  4 +-
 src/ui/snapshot-row.vala                           |  8 ++--
 src/ui/snapshots-list.vala                         | 18 ++++----
 35 files changed, 143 insertions(+), 143 deletions(-)
---
diff --git a/plugins/nintendo-64/src/nintendo-64-pak-controller.vala 
b/plugins/nintendo-64/src/nintendo-64-pak-controller.vala
index fa6a48a1..d7656812 100644
--- a/plugins/nintendo-64/src/nintendo-64-pak-controller.vala
+++ b/plugins/nintendo-64/src/nintendo-64-pak-controller.vala
@@ -3,11 +3,11 @@
 [GtkTemplate (ui = "/org/gnome/Games/plugins/nintendo-64/nintendo-64-pak-controller.ui")]
 private class Games.Nintendo64PakController : Gtk.Box {
        [GtkChild]
-       private Gtk.Label title;
+       private unowned Gtk.Label title;
        [GtkChild]
-       private Gtk.ModelButton memory_btn;
+       private unowned Gtk.ModelButton memory_btn;
        [GtkChild]
-       private Gtk.ModelButton rumble_btn;
+       private unowned Gtk.ModelButton rumble_btn;
 
        public Retro.Controller gamepad { get; construct; }
        public uint port { get; construct; }
diff --git a/plugins/nintendo-64/src/nintendo-64-pak-switcher.vala 
b/plugins/nintendo-64/src/nintendo-64-pak-switcher.vala
index 0a4b881c..d699a59a 100644
--- a/plugins/nintendo-64/src/nintendo-64-pak-switcher.vala
+++ b/plugins/nintendo-64/src/nintendo-64-pak-switcher.vala
@@ -3,9 +3,9 @@
 [GtkTemplate (ui = "/org/gnome/Games/plugins/nintendo-64/nintendo-64-pak-switcher.ui")]
 private class Games.Nintendo64PakSwitcher : Gtk.Bin, HeaderBarWidget {
        [GtkChild]
-       private Gtk.MenuButton menu_button;
+       private unowned Gtk.MenuButton menu_button;
        [GtkChild]
-       private Gtk.Box controllers_box;
+       private unowned Gtk.Box controllers_box;
 
        public Nintendo64Runner runner { get; construct; }
 
diff --git a/src/gamepad/gamepad-mapper.vala b/src/gamepad/gamepad-mapper.vala
index eaac6a1d..9538a18c 100644
--- a/src/gamepad/gamepad-mapper.vala
+++ b/src/gamepad/gamepad-mapper.vala
@@ -7,7 +7,7 @@ private class Games.GamepadMapper : Gtk.Bin {
        public signal void finished (string sdl_string);
 
        [GtkChild]
-       private GamepadView gamepad_view;
+       private unowned GamepadView gamepad_view;
 
        private GamepadMappingBuilder mapping_builder;
        private GamepadInput[] mapping_inputs;
diff --git a/src/gamepad/gamepad-tester.vala b/src/gamepad/gamepad-tester.vala
index 59d052db..96bf7ae6 100644
--- a/src/gamepad/gamepad-tester.vala
+++ b/src/gamepad/gamepad-tester.vala
@@ -3,7 +3,7 @@
 [GtkTemplate (ui = "/org/gnome/Games/gamepad/gamepad-tester.ui")]
 private class Games.GamepadTester : Gtk.Bin {
        [GtkChild]
-       private GamepadView gamepad_view;
+       private unowned GamepadView gamepad_view;
 
        private ulong gamepad_button_press_event_handler_id;
        private ulong gamepad_button_release_event_handler_id;
diff --git a/src/keyboard/keyboard-mapper.vala b/src/keyboard/keyboard-mapper.vala
index 5b320d1d..75e052a0 100644
--- a/src/keyboard/keyboard-mapper.vala
+++ b/src/keyboard/keyboard-mapper.vala
@@ -5,7 +5,7 @@ private class Games.KeyboardMapper : Gtk.Bin {
        public signal void finished (Retro.KeyJoypadMapping mapping);
 
        [GtkChild]
-       private GamepadView gamepad_view;
+       private unowned GamepadView gamepad_view;
 
        private KeyboardMappingBuilder mapping_builder;
        private GamepadInput[] mapping_inputs;
diff --git a/src/keyboard/keyboard-tester.vala b/src/keyboard/keyboard-tester.vala
index 3ec09cec..c4963997 100644
--- a/src/keyboard/keyboard-tester.vala
+++ b/src/keyboard/keyboard-tester.vala
@@ -3,7 +3,7 @@
 [GtkTemplate (ui = "/org/gnome/Games/keyboard/keyboard-tester.ui")]
 private class Games.KeyboardTester : Gtk.Bin {
        [GtkChild]
-       private GamepadView gamepad_view;
+       private unowned GamepadView gamepad_view;
 
        public Retro.KeyJoypadMapping mapping { get; set; }
 
diff --git a/src/preferences/preferences-page-controllers.vala 
b/src/preferences/preferences-page-controllers.vala
index f0a4aca6..b169de21 100644
--- a/src/preferences/preferences-page-controllers.vala
+++ b/src/preferences/preferences-page-controllers.vala
@@ -3,9 +3,9 @@
 [GtkTemplate (ui = "/org/gnome/Games/preferences/preferences-page-controllers.ui")]
 private class Games.PreferencesPageControllers : PreferencesPage {
        [GtkChild]
-       private Hdy.PreferencesGroup gamepads_group;
+       private unowned Hdy.PreferencesGroup gamepads_group;
        [GtkChild]
-       private Hdy.PreferencesGroup keyboard_group;
+       private unowned Hdy.PreferencesGroup keyboard_group;
 
        private Manette.Monitor monitor;
 
diff --git a/src/preferences/preferences-page-platforms.vala b/src/preferences/preferences-page-platforms.vala
index 058ac53b..698109c9 100644
--- a/src/preferences/preferences-page-platforms.vala
+++ b/src/preferences/preferences-page-platforms.vala
@@ -3,7 +3,7 @@
 [GtkTemplate (ui = "/org/gnome/Games/preferences/preferences-page-platforms.ui")]
 private class Games.PreferencesPagePlatforms : PreferencesPage {
        [GtkChild]
-       private Hdy.PreferencesGroup platforms_group;
+       private unowned Hdy.PreferencesGroup platforms_group;
 
        construct {
                var register = PlatformRegister.get_register ();
diff --git a/src/preferences/preferences-page-video.vala b/src/preferences/preferences-page-video.vala
index 2901812f..9d667d24 100644
--- a/src/preferences/preferences-page-video.vala
+++ b/src/preferences/preferences-page-video.vala
@@ -17,7 +17,7 @@ private class Games.PreferencesPageVideo : PreferencesPage {
        }
 
        [GtkChild]
-       private Hdy.PreferencesGroup filter_group;
+       private unowned Hdy.PreferencesGroup filter_group;
 
        // same as video-filters in gschema
        /* Translators: These values are video filters applied to the screen. Smooth
diff --git a/src/preferences/preferences-page.vala b/src/preferences/preferences-page.vala
index d131fec0..c8a1156b 100644
--- a/src/preferences/preferences-page.vala
+++ b/src/preferences/preferences-page.vala
@@ -5,11 +5,11 @@ private class Games.PreferencesPage : Gtk.Bin, Gtk.Buildable {
        public PreferencesWindow window { get; construct; }
 
        [GtkChild]
-       private Gtk.Label error_label;
+       private unowned Gtk.Label error_label;
        [GtkChild]
-       private Gtk.Revealer error_notification_revealer;
+       private unowned Gtk.Revealer error_notification_revealer;
        [GtkChild]
-       private Gtk.Box box;
+       private unowned Gtk.Box box;
 
        [GtkCallback]
        private void on_error_notification_closed () {
diff --git a/src/preferences/preferences-subpage-gamepad.vala 
b/src/preferences/preferences-subpage-gamepad.vala
index 61bf7fa2..e09a02da 100644
--- a/src/preferences/preferences-subpage-gamepad.vala
+++ b/src/preferences/preferences-subpage-gamepad.vala
@@ -65,17 +65,17 @@ private class Games.PreferencesSubpageGamepad : Gtk.Bin, PreferencesSubpage {
        public string info_message { get; set; }
 
        [GtkChild]
-       private Gtk.Stack stack;
+       private unowned Gtk.Stack stack;
        [GtkChild]
-       private Gtk.Box tester_box;
+       private unowned Gtk.Box tester_box;
        [GtkChild]
-       private Gtk.Box mapper_box;
+       private unowned Gtk.Box mapper_box;
        [GtkChild]
-       private Gtk.HeaderBar tester_header_bar;
+       private unowned Gtk.HeaderBar tester_header_bar;
        [GtkChild]
-       private Gtk.HeaderBar mapper_header_bar;
+       private unowned Gtk.HeaderBar mapper_header_bar;
        [GtkChild]
-       private Gtk.Button reset_button;
+       private unowned Gtk.Button reset_button;
 
        private GamepadMapper mapper;
        private GamepadTester tester;
diff --git a/src/preferences/preferences-subpage-keyboard.vala 
b/src/preferences/preferences-subpage-keyboard.vala
index 8782d8b3..9bc5df0a 100644
--- a/src/preferences/preferences-subpage-keyboard.vala
+++ b/src/preferences/preferences-subpage-keyboard.vala
@@ -60,13 +60,13 @@ private class Games.PreferencesSubpageKeyboard : Gtk.Bin, PreferencesSubpage {
        public string info_message { get; set; }
 
        [GtkChild]
-       private Gtk.Stack stack;
+       private unowned Gtk.Stack stack;
        [GtkChild]
-       private Gtk.Box tester_box;
+       private unowned Gtk.Box tester_box;
        [GtkChild]
-       private Gtk.Box mapper_box;
+       private unowned Gtk.Box mapper_box;
        [GtkChild]
-       private Gtk.Button reset_button;
+       private unowned Gtk.Button reset_button;
 
        private KeyboardMapper mapper;
        private KeyboardTester tester;
diff --git a/src/preferences/preferences-window.vala b/src/preferences/preferences-window.vala
index ff646177..17bfc301 100644
--- a/src/preferences/preferences-window.vala
+++ b/src/preferences/preferences-window.vala
@@ -3,11 +3,11 @@
 [GtkTemplate (ui = "/org/gnome/Games/preferences/preferences-window.ui")]
 private class Games.PreferencesWindow : Hdy.Window {
        [GtkChild]
-       private Hdy.Deck deck;
+       private unowned Hdy.Deck deck;
        [GtkChild]
-       private Gtk.Box main_box;
+       private unowned Gtk.Box main_box;
        [GtkChild]
-       private Gtk.Box subpage_box;
+       private unowned Gtk.Box subpage_box;
 
        private PreferencesSubpage subpage;
        private Binding swipe_back_binding;
diff --git a/src/screen-layout/screen-layout-item.vala b/src/screen-layout/screen-layout-item.vala
index 7007783a..1c0e9b9a 100644
--- a/src/screen-layout/screen-layout-item.vala
+++ b/src/screen-layout/screen-layout-item.vala
@@ -3,11 +3,11 @@
 [GtkTemplate (ui = "/org/gnome/Games/screen-layout/screen-layout-item.ui")]
 private class Games.ScreenLayoutItem : Gtk.ListBoxRow {
        [GtkChild]
-       private Gtk.Image icon;
+       private unowned Gtk.Image icon;
        [GtkChild]
-       private Gtk.Label title;
+       private unowned Gtk.Label title;
        [GtkChild]
-       private Gtk.Image checkmark;
+       private unowned Gtk.Image checkmark;
 
        public ScreenLayout layout { get; construct; }
 
diff --git a/src/screen-layout/screen-layout-switcher.vala b/src/screen-layout/screen-layout-switcher.vala
index bd0b824f..2c8427b1 100644
--- a/src/screen-layout/screen-layout-switcher.vala
+++ b/src/screen-layout/screen-layout-switcher.vala
@@ -3,17 +3,17 @@
 [GtkTemplate (ui = "/org/gnome/Games/screen-layout/screen-layout-switcher.ui")]
 public class Games.ScreenLayoutSwitcher : Gtk.Box, HeaderBarWidget {
        [GtkChild]
-       private Gtk.Revealer change_screen_revealer;
+       private unowned Gtk.Revealer change_screen_revealer;
        [GtkChild]
-       private Gtk.Image change_screen_image;
+       private unowned Gtk.Image change_screen_image;
        [GtkChild]
-       private Gtk.MenuButton layout_button;
+       private unowned Gtk.MenuButton layout_button;
        [GtkChild]
-       private Gtk.Image layout_image;
+       private unowned Gtk.Image layout_image;
        [GtkChild]
-       private Gtk.Popover layout_popover;
+       private unowned Gtk.Popover layout_popover;
        [GtkChild]
-       private Gtk.ListBox list_box;
+       private unowned Gtk.ListBox list_box;
 
        private HashTable<ScreenLayout, ScreenLayoutItem> items;
 
diff --git a/src/ui/application-window.vala b/src/ui/application-window.vala
index 514315a8..04f34f95 100644
--- a/src/ui/application-window.vala
+++ b/src/ui/application-window.vala
@@ -5,11 +5,11 @@ private class Games.ApplicationWindow : Hdy.ApplicationWindow {
        private const uint WINDOW_SIZE_UPDATE_DELAY_MILLISECONDS = 500;
 
        [GtkChild]
-       private Gtk.Stack stack;
+       private unowned Gtk.Stack stack;
        [GtkChild]
-       private CollectionView collection_view;
+       private unowned CollectionView collection_view;
        [GtkChild]
-       private DisplayView display_view;
+       private unowned DisplayView display_view;
 
        private UiView _current_view;
        public UiView current_view {
diff --git a/src/ui/collection-action-window.vala b/src/ui/collection-action-window.vala
index 15ad6272..d791367e 100644
--- a/src/ui/collection-action-window.vala
+++ b/src/ui/collection-action-window.vala
@@ -5,29 +5,29 @@ private class Games.CollectionActionWindow : Hdy.Window {
        public signal void confirmed (Collection[] collections);
 
        [GtkChild]
-       private Hdy.Deck deck;
+       private unowned Hdy.Deck deck;
        [GtkChild]
-       private Gtk.Box add_to_collection_page;
+       private unowned Gtk.Box add_to_collection_page;
        [GtkChild]
-       private Gtk.Box create_collection_page;
+       private unowned Gtk.Box create_collection_page;
        [GtkChild]
-       private Gtk.Stack user_collections_page_stack;
+       private unowned Gtk.Stack user_collections_page_stack;
        [GtkChild]
-       private Gtk.ScrolledWindow list_page;
+       private unowned Gtk.ScrolledWindow list_page;
        [GtkChild]
-       private Hdy.StatusPage empty_page;
+       private unowned Hdy.StatusPage empty_page;
        [GtkChild]
-       private Gtk.Entry name_entry;
+       private unowned Gtk.Entry name_entry;
        [GtkChild]
-       private Gtk.Label error_label;
+       private unowned Gtk.Label error_label;
        [GtkChild]
-       private Gtk.ListBox list_box;
+       private unowned Gtk.ListBox list_box;
        [GtkChild]
-       private Hdy.SearchBar search_bar;
+       private unowned Hdy.SearchBar search_bar;
        [GtkChild]
-       private Gtk.SearchEntry search_entry;
+       private unowned Gtk.SearchEntry search_entry;
        [GtkChild]
-       private Gtk.ListBoxRow add_row;
+       private unowned Gtk.ListBoxRow add_row;
 
        private CollectionManager collection_manager;
        private SimpleActionGroup action_group;
diff --git a/src/ui/collection-icon-view.vala b/src/ui/collection-icon-view.vala
index 8857111d..1722d8ba 100644
--- a/src/ui/collection-icon-view.vala
+++ b/src/ui/collection-icon-view.vala
@@ -3,9 +3,9 @@
 [GtkTemplate (ui = "/org/gnome/Games/ui/collection-icon-view.ui")]
 private class Games.CollectionIconView : Gtk.FlowBoxChild {
        [GtkChild]
-       private Gtk.Label title;
+       private unowned Gtk.Label title;
        [GtkChild]
-       private CollectionThumbnail thumbnail;
+       private unowned CollectionThumbnail thumbnail;
 
        public bool checked { get; set; }
        public bool is_selection_mode { get; set; }
diff --git a/src/ui/collection-thumbnail.vala b/src/ui/collection-thumbnail.vala
index 41ca8149..0137154c 100644
--- a/src/ui/collection-thumbnail.vala
+++ b/src/ui/collection-thumbnail.vala
@@ -7,11 +7,11 @@ private class Games.CollectionThumbnail : Gtk.Bin {
        const uint N_COLUMNS = 2;
 
        [GtkChild]
-       private Gtk.Stack thumbnail_stack;
+       private unowned Gtk.Stack thumbnail_stack;
        [GtkChild]
-       private Gtk.Grid grid;
+       private unowned Gtk.Grid grid;
        [GtkChild]
-       private Gtk.Image new_collection_image;
+       private unowned Gtk.Image new_collection_image;
 
        private ulong games_changed_id = 0;
 
diff --git a/src/ui/collection-view.vala b/src/ui/collection-view.vala
index 42b4f540..39d8a9e7 100644
--- a/src/ui/collection-view.vala
+++ b/src/ui/collection-view.vala
@@ -7,57 +7,57 @@ private class Games.CollectionView : Gtk.Box, UiView {
        public signal void game_activated (Game game);
 
        [GtkChild]
-       private Hdy.Deck platforms_deck;
+       private unowned Hdy.Deck platforms_deck;
        [GtkChild]
-       private Hdy.Deck collections_deck;
+       private unowned Hdy.Deck collections_deck;
        [GtkChild]
-       private Gtk.Stack header_bar_stack;
+       private unowned Gtk.Stack header_bar_stack;
        [GtkChild]
-       private Hdy.HeaderBar header_bar;
+       private unowned Hdy.HeaderBar header_bar;
        [GtkChild]
-       private Hdy.HeaderBar subview_header_bar;
+       private unowned Hdy.HeaderBar subview_header_bar;
        [GtkChild]
-       private Hdy.HeaderBar selection_mode_header_bar;
+       private unowned Hdy.HeaderBar selection_mode_header_bar;
        [GtkChild]
-       private Hdy.ViewSwitcherTitle view_switcher_title;
+       private unowned Hdy.ViewSwitcherTitle view_switcher_title;
        [GtkChild]
-       private ErrorInfoBar error_info_bar;
+       private unowned ErrorInfoBar error_info_bar;
        [GtkChild]
-       private SearchBar search_bar;
+       private unowned SearchBar search_bar;
        [GtkChild]
-       private Hdy.StatusPage empty_collection;
+       private unowned Hdy.StatusPage empty_collection;
        [GtkChild]
-       private Hdy.StatusPage empty_search;
+       private unowned Hdy.StatusPage empty_search;
        [GtkChild]
-       private GamesPage games_page;
+       private unowned GamesPage games_page;
        [GtkChild]
-       private PlatformsPage platforms_page;
+       private unowned PlatformsPage platforms_page;
        [GtkChild]
-       private CollectionsPage collections_page;
+       private unowned CollectionsPage collections_page;
        [GtkChild]
-       private Hdy.HeaderBar collection_subpage_header_bar;
+       private unowned Hdy.HeaderBar collection_subpage_header_bar;
        [GtkChild]
-       private SelectionActionBar selection_action_bar;
+       private unowned SelectionActionBar selection_action_bar;
        [GtkChild]
-       private Gtk.Stack empty_stack;
+       private unowned Gtk.Stack empty_stack;
        [GtkChild]
-       private Gtk.Stack viewstack;
+       private unowned Gtk.Stack viewstack;
        [GtkChild]
-       private Hdy.ViewSwitcherBar view_switcher_bar;
+       private unowned Hdy.ViewSwitcherBar view_switcher_bar;
        [GtkChild]
-       private Hdy.SwipeGroup swipe_group;
+       private unowned Hdy.SwipeGroup swipe_group;
        [GtkChild]
-       private Hdy.SwipeGroup collections_swipe_group;
+       private unowned Hdy.SwipeGroup collections_swipe_group;
        [GtkChild]
-       private UndoNotification undo_notification;
+       private unowned UndoNotification undo_notification;
        [GtkChild]
-       private Gtk.Entry collection_rename_entry;
+       private unowned Gtk.Entry collection_rename_entry;
        [GtkChild]
-       private Gtk.Popover rename_popover;
+       private unowned Gtk.Popover rename_popover;
        [GtkChild]
-       private Gtk.Label collection_rename_error_label;
+       private unowned Gtk.Label collection_rename_error_label;
        [GtkChild]
-       private Gtk.Label selection_mode_label;
+       private unowned Gtk.Label selection_mode_label;
 
        private bool _is_view_active;
        public bool is_view_active {
diff --git a/src/ui/collections-main-page.vala b/src/ui/collections-main-page.vala
index 2b36f433..e96892a8 100644
--- a/src/ui/collections-main-page.vala
+++ b/src/ui/collections-main-page.vala
@@ -7,11 +7,11 @@ private class Games.CollectionsMainPage : Gtk.Bin {
        public signal void gamepad_accepted ();
 
        [GtkChild]
-       private Gtk.FlowBox flow_box;
+       private unowned Gtk.FlowBox flow_box;
        [GtkChild]
-       private GamepadBrowse gamepad_browse;
+       private unowned GamepadBrowse gamepad_browse;
        [GtkChild]
-       private Gtk.ScrolledWindow scrolled_window;
+       private unowned Gtk.ScrolledWindow scrolled_window;
 
        private string[] filtering_terms;
        private Binding window_active_binding;
diff --git a/src/ui/collections-page.vala b/src/ui/collections-page.vala
index a43a0837..e28dd572 100644
--- a/src/ui/collections-page.vala
+++ b/src/ui/collections-page.vala
@@ -6,15 +6,15 @@ private class Games.CollectionsPage : Gtk.Bin {
        public signal void selected_items_changed ();
 
        [GtkChild]
-       private Hdy.Deck collections_deck;
+       private unowned Hdy.Deck collections_deck;
        [GtkChild]
-       private CollectionsMainPage collections_main_page;
+       private unowned CollectionsMainPage collections_main_page;
        [GtkChild]
-       private Gtk.Stack collections_subpage_stack;
+       private unowned Gtk.Stack collections_subpage_stack;
        [GtkChild]
-       private GamesPage collections_subpage;
+       private unowned GamesPage collections_subpage;
        [GtkChild]
-       private Hdy.StatusPage collection_empty_subpage;
+       private unowned Hdy.StatusPage collection_empty_subpage;
 
        private UserCollection[]? last_removed_collections;
        private CollectionManager collection_manager;
diff --git a/src/ui/display-view.vala b/src/ui/display-view.vala
index 571e90eb..db8f1e57 100644
--- a/src/ui/display-view.vala
+++ b/src/ui/display-view.vala
@@ -7,37 +7,37 @@ private class Games.DisplayView : Gtk.Box, UiView {
        public signal void back ();
 
        [GtkChild]
-       private Gtk.Stack headerbar_stack;
+       private unowned Gtk.Stack headerbar_stack;
        [GtkChild]
-       private Hdy.HeaderBar ingame_header_bar;
+       private unowned Hdy.HeaderBar ingame_header_bar;
        [GtkChild]
-       private Gtk.Button fullscreen;
+       private unowned Gtk.Button fullscreen;
        [GtkChild]
-       private Gtk.Button restore;
+       private unowned Gtk.Button restore;
        [GtkChild]
-       private Gtk.MenuButton secondary_menu_button;
+       private unowned Gtk.MenuButton secondary_menu_button;
        [GtkChild]
-       private Hdy.HeaderBar snapshots_header_bar;
+       private unowned Hdy.HeaderBar snapshots_header_bar;
        [GtkChild]
-       private MediaMenuButton media_button;
+       private unowned MediaMenuButton media_button;
        [GtkChild]
-       private InputModeSwitcher input_mode_switcher;
+       private unowned InputModeSwitcher input_mode_switcher;
        [GtkChild]
-       private Gtk.Stack stack;
+       private unowned Gtk.Stack stack;
        [GtkChild]
-       private Hdy.StatusPage error_display;
+       private unowned Hdy.StatusPage error_display;
        [GtkChild]
-       private Gtk.Button restart_btn;
+       private unowned Gtk.Button restart_btn;
        [GtkChild]
-       private Gtk.Box display_box;
+       private unowned Gtk.Box display_box;
        [GtkChild]
-       private DisplayBin display_bin;
+       private unowned DisplayBin display_bin;
        [GtkChild]
-       private FullscreenBox fullscreen_box;
+       private unowned FullscreenBox fullscreen_box;
        [GtkChild]
-       private FlashBox flash_box;
+       private unowned FlashBox flash_box;
        [GtkChild]
-       private SnapshotsList snapshots_list;
+       private unowned SnapshotsList snapshots_list;
 
        private bool _is_view_active;
        public bool is_view_active {
diff --git a/src/ui/error-info-bar.vala b/src/ui/error-info-bar.vala
index 5b632511..bd2efd76 100644
--- a/src/ui/error-info-bar.vala
+++ b/src/ui/error-info-bar.vala
@@ -3,9 +3,9 @@
 [GtkTemplate (ui = "/org/gnome/Games/ui/error-info-bar.ui")]
 private class Games.ErrorInfoBar : Gtk.Bin {
        [GtkChild]
-       private Gtk.InfoBar info_bar;
+       private unowned Gtk.InfoBar info_bar;
        [GtkChild]
-       private Gtk.Label label;
+       private unowned Gtk.Label label;
 
        [GtkCallback]
        private void on_response () {
diff --git a/src/ui/fullscreen-box.vala b/src/ui/fullscreen-box.vala
index d53fdb58..99425855 100644
--- a/src/ui/fullscreen-box.vala
+++ b/src/ui/fullscreen-box.vala
@@ -57,7 +57,7 @@ private class Games.FullscreenBox : Gtk.EventBox, Gtk.Buildable {
        }
 
        [GtkChild]
-       private TitlebarBox titlebar_box;
+       private unowned TitlebarBox titlebar_box;
 
        private uint ui_timeout_id;
        private uint cursor_timeout_id;
diff --git a/src/ui/game-icon-view.vala b/src/ui/game-icon-view.vala
index d946ff34..605be5f9 100644
--- a/src/ui/game-icon-view.vala
+++ b/src/ui/game-icon-view.vala
@@ -3,9 +3,9 @@
 [GtkTemplate (ui = "/org/gnome/Games/ui/game-icon-view.ui")]
 private class Games.GameIconView : Gtk.FlowBoxChild {
        [GtkChild]
-       private GameThumbnail thumbnail;
+       private unowned GameThumbnail thumbnail;
        [GtkChild]
-       private Gtk.Label title;
+       private unowned Gtk.Label title;
 
        private ulong game_replaced_id;
 
diff --git a/src/ui/games-page.vala b/src/ui/games-page.vala
index 2df58226..27a2dee9 100644
--- a/src/ui/games-page.vala
+++ b/src/ui/games-page.vala
@@ -54,12 +54,12 @@ private class Games.GamesPage : Gtk.Bin {
        }
 
        [GtkChild]
-       private Gtk.ScrolledWindow scrolled_window;
+       private unowned Gtk.ScrolledWindow scrolled_window;
        [GtkChild]
-       private Gtk.FlowBox flow_box;
+       private unowned Gtk.FlowBox flow_box;
 
        [GtkChild]
-       private GamepadBrowse gamepad_browse;
+       private unowned GamepadBrowse gamepad_browse;
 
        public bool is_search_empty { get; set; }
 
diff --git a/src/ui/input-mode-switcher.vala b/src/ui/input-mode-switcher.vala
index d808f040..c1bb05c6 100644
--- a/src/ui/input-mode-switcher.vala
+++ b/src/ui/input-mode-switcher.vala
@@ -23,9 +23,9 @@ private class Games.InputModeSwitcher : Gtk.Box {
        }
 
        [GtkChild]
-       private Gtk.RadioButton keyboard_mode;
+       private unowned Gtk.RadioButton keyboard_mode;
        [GtkChild]
-       private Gtk.RadioButton gamepad_mode;
+       private unowned Gtk.RadioButton gamepad_mode;
 
        [GtkCallback]
        private void on_keyboard_button_toggled () {
diff --git a/src/ui/media-menu-button.vala b/src/ui/media-menu-button.vala
index a1a9ec17..9d34e178 100644
--- a/src/ui/media-menu-button.vala
+++ b/src/ui/media-menu-button.vala
@@ -3,11 +3,11 @@
 [GtkTemplate (ui = "/org/gnome/Games/ui/media-menu-button.ui")]
 private class Games.MediaMenuButton : Gtk.Bin {
        [GtkChild]
-       private Gtk.Image media_image;
+       private unowned Gtk.Image media_image;
        [GtkChild]
-       private Gtk.Popover popover;
+       private unowned Gtk.Popover popover;
        [GtkChild]
-       private Gtk.ListBox list_box;
+       private unowned Gtk.ListBox list_box;
 
        public bool active { get; set; }
 
diff --git a/src/ui/platform-list-item.vala b/src/ui/platform-list-item.vala
index 653910d9..8acff251 100644
--- a/src/ui/platform-list-item.vala
+++ b/src/ui/platform-list-item.vala
@@ -3,7 +3,7 @@
 [GtkTemplate (ui = "/org/gnome/Games/ui/platform-list-item.ui")]
 private class Games.PlatformListItem : Gtk.ListBoxRow {
        [GtkChild]
-       protected Gtk.Label label;
+       protected unowned Gtk.Label label;
 
        public Platform platform { get; construct; }
 
diff --git a/src/ui/platforms-page.vala b/src/ui/platforms-page.vala
index fc445c89..7742da6f 100644
--- a/src/ui/platforms-page.vala
+++ b/src/ui/platforms-page.vala
@@ -6,13 +6,13 @@ private class Games.PlatformsPage : Gtk.Bin {
        public signal void selected_items_changed ();
 
        [GtkChild]
-       private Hdy.Leaflet leaflet;
+       private unowned Hdy.Leaflet leaflet;
        [GtkChild]
-       private Gtk.ListBox list_box;
+       private unowned Gtk.ListBox list_box;
        [GtkChild]
-       private GamesPage games_page;
+       private unowned GamesPage games_page;
        [GtkChild]
-       private GamepadBrowse gamepad_browse;
+       private unowned GamepadBrowse gamepad_browse;
 
        private Platform selected_platform;
        private bool has_used_gamepad;
diff --git a/src/ui/search-bar.vala b/src/ui/search-bar.vala
index fa06fea6..7c6a95f8 100644
--- a/src/ui/search-bar.vala
+++ b/src/ui/search-bar.vala
@@ -6,9 +6,9 @@ private class Games.SearchBar : Gtk.Bin {
        public bool search_mode_enabled { get; set; }
 
        [GtkChild]
-       private Hdy.SearchBar search_bar;
+       private unowned Hdy.SearchBar search_bar;
        [GtkChild]
-       private Gtk.SearchEntry entry;
+       private unowned Gtk.SearchEntry entry;
 
        construct {
                search_bar.connect_entry (entry);
diff --git a/src/ui/selection-action-bar.vala b/src/ui/selection-action-bar.vala
index e54ec333..21f65ac6 100644
--- a/src/ui/selection-action-bar.vala
+++ b/src/ui/selection-action-bar.vala
@@ -3,9 +3,9 @@
 [GtkTemplate (ui = "/org/gnome/Games/ui/selection-action-bar.ui")]
 private class Games.SelectionActionBar : Gtk.ActionBar {
        [GtkChild]
-       private Gtk.Stack icon_stack;
+       private unowned Gtk.Stack icon_stack;
        [GtkChild]
-       private Gtk.Button favorite_button;
+       private unowned Gtk.Button favorite_button;
 
        private FavoriteState _favorite_state;
        public FavoriteState favorite_state {
diff --git a/src/ui/snapshot-row.vala b/src/ui/snapshot-row.vala
index 2bf065cf..05871c7b 100644
--- a/src/ui/snapshot-row.vala
+++ b/src/ui/snapshot-row.vala
@@ -3,13 +3,13 @@
 [GtkTemplate (ui = "/org/gnome/Games/ui/snapshot-row.ui")]
 private class Games.SnapshotRow : Gtk.ListBoxRow {
        [GtkChild]
-       private SnapshotThumbnail thumbnail;
+       private unowned SnapshotThumbnail thumbnail;
        [GtkChild]
-       private Gtk.Label name_label;
+       private unowned Gtk.Label name_label;
        [GtkChild]
-       private Gtk.Label date_label;
+       private unowned Gtk.Label date_label;
        [GtkChild]
-       private Gtk.Revealer revealer;
+       private unowned Gtk.Revealer revealer;
 
        private Snapshot _snapshot;
        public Snapshot snapshot {
diff --git a/src/ui/snapshots-list.vala b/src/ui/snapshots-list.vala
index e36bffad..344b6601 100644
--- a/src/ui/snapshots-list.vala
+++ b/src/ui/snapshots-list.vala
@@ -5,24 +5,24 @@ private class Games.SnapshotsList : Gtk.Box {
        public signal void hidden ();
 
        [GtkChild]
-       private Gtk.ListBox list_box;
+       private unowned Gtk.ListBox list_box;
        [GtkChild]
-       private Gtk.ListBoxRow new_snapshot_row;
+       private unowned Gtk.ListBoxRow new_snapshot_row;
        [GtkChild]
-       private Gtk.ScrolledWindow scrolled_window;
+       private unowned Gtk.ScrolledWindow scrolled_window;
        [GtkChild]
-       private Gtk.Button delete_btn;
+       private unowned Gtk.Button delete_btn;
        [GtkChild]
-       private Gtk.Button rename_btn;
+       private unowned Gtk.Button rename_btn;
 
        [GtkChild]
-       private Gtk.Popover rename_popover;
+       private unowned Gtk.Popover rename_popover;
        [GtkChild]
-       private Gtk.Entry rename_entry;
+       private unowned Gtk.Entry rename_entry;
        [GtkChild]
-       private Gtk.Button rename_popover_btn;
+       private unowned Gtk.Button rename_popover_btn;
        [GtkChild]
-       private Gtk.Label rename_error_label;
+       private unowned Gtk.Label rename_error_label;
 
        private Snapshot selected_snapshot;
[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]