[orca/gnome-3-36] Revert "Don't present image children of links if the image lacks an explicit name"



commit a0766ea4837482badd12a694217722859853e4fc
Author: Joanmarie Diggs <jdiggs igalia com>
Date:   Sat May 23 13:50:07 2020 -0400

    Revert "Don't present image children of links if the image lacks an explicit name"
    
    This reverts commit 5f7c77e94a7f19e1c255436fb367f270a59c24f0.
    
    It introduced a weird side effect.

 src/orca/scripts/web/script_utilities.py | 4 ++++
 1 file changed, 4 insertions(+)
---
diff --git a/src/orca/scripts/web/script_utilities.py b/src/orca/scripts/web/script_utilities.py
index 753627d48..57ec71ca1 100644
--- a/src/orca/scripts/web/script_utilities.py
+++ b/src/orca/scripts/web/script_utilities.py
@@ -3626,6 +3626,10 @@ class Utilities(script_utilities.Utilities):
             rv = False
         if rv and obj.getState().contains(pyatspi.STATE_FOCUSABLE):
             rv = False
+        if rv and obj.parent.getRole() == pyatspi.ROLE_LINK:
+            uri = self.uri(obj.parent)
+            if uri and not uri.startswith('javascript'):
+                rv = False
         if rv and 'Image' in pyatspi.listInterfaces(obj):
             image = obj.queryImage()
             if image.imageDescription:


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]