[libgda: 2/3] PostgreSQL: WITH OIDS parameter was removed

[Daniel Espinosa Ortiz <despinosa src gnome org>]

commit 0de7d78a5a484126523efb58c115e5cdc304f12e
Author: Pavlo Solntsev <p sun fun gmail com>
Date:   Tue Feb 18 21:54:11 2020 -0600

    PostgreSQL: WITH OIDS parameter was removed
    
    See https://gitlab.gnome.org/GNOME/libgda/merge_requests/131

 providers/postgres/gda-postgres-ddl.c              | 26 ----------------------
 .../postgres/postgres_specs_create_table.xml.in    |  3 ---
 2 files changed, 29 deletions(-)
---
diff --git a/providers/postgres/gda-postgres-ddl.c b/providers/postgres/gda-postgres-ddl.c
index 5ebc9f8df..2ffb94244 100644
--- a/providers/postgres/gda-postgres-ddl.c
+++ b/providers/postgres/gda-postgres-ddl.c
@@ -404,32 +404,6 @@ gda_postgres_render_CREATE_TABLE (GdaServerProvider *provider, GdaConnection *cn
                return NULL;
        }
 
-       value = gda_server_operation_get_value_at (op, "/TABLE_DEF_P/TABLE_WITH_OIDS");
-    if (value && G_VALUE_HOLDS (value, G_TYPE_BOOLEAN) && g_value_get_boolean (value)) {
-        const gchar *server_version = gda_server_provider_get_server_version (provider, cnc);
-
-        if (server_version) {
-
-            gchar **setstring = g_strsplit(server_version, " ", -1);
-
-            if (setstring) {
-                const gchar *t_version = setstring[1]; // We need a second element from the array
-
-                if (t_version) {
-                    if (!g_strcmp0(t_version, "9.4.26") ||
-                        !g_strcmp0(t_version, "9.5.21") ||
-                        !g_strcmp0(t_version, "9.6.17") ||
-                        !g_strcmp0(t_version, "10.12") ||
-                        !g_strcmp0(t_version, "11.7")) {
-                        g_string_append (string, " WITH OIDS");
-                    }
-                }
-
-                g_strfreev(setstring);
-            }
-        }
-    }
-
        sql = string->str;
        g_string_free (string, FALSE);
 
diff --git a/providers/postgres/postgres_specs_create_table.xml.in 
b/providers/postgres/postgres_specs_create_table.xml.in
index ee8008106..351e70dee 100644
--- a/providers/postgres/postgres_specs_create_table.xml.in
+++ b/providers/postgres/postgres_specs_create_table.xml.in
@@ -5,9 +5,6 @@
       <gda_value>table_name</gda_value>
     </parameter>
     <parameter id="TABLE_TABLESPACE" _name="Tablespace" gdatype="gchararray" nullok="TRUE"/>
-    <parameter id="TABLE_WITH_OIDS" _name="With OIDs" gdatype="gboolean" nullok="TRUE">
-      <gda_value>TRUE</gda_value>
-    </parameter>
     <parameter id="TABLE_TEMP" _name="Temporary table" gdatype="gboolean" nullok="TRUE">
       <gda_value>FALSE</gda_value>
     </parameter>