[libgda: 1/3] PostgreSQL: Fixing WITH OIDS flagg for >11 version
- From: Daniel Espinosa Ortiz <despinosa src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [libgda: 1/3] PostgreSQL: Fixing WITH OIDS flagg for >11 version
- Date: Fri, 6 Mar 2020 19:13:09 +0000 (UTC)
commit 2665350c85b30b002844a3e9702fdab4e389d3a3
Author: Pavlo Solntsev <p sun fun gmail com>
Date: Mon Feb 17 14:44:30 2020 -0600
PostgreSQL: Fixing WITH OIDS flagg for >11 version
See https://gitlab.gnome.org/GNOME/libgda/issues/209
providers/postgres/gda-postgres-ddl.c | 29 +++++++++++++++++++++++++++--
1 file changed, 27 insertions(+), 2 deletions(-)
---
diff --git a/providers/postgres/gda-postgres-ddl.c b/providers/postgres/gda-postgres-ddl.c
index 15f59047c..5ebc9f8df 100644
--- a/providers/postgres/gda-postgres-ddl.c
+++ b/providers/postgres/gda-postgres-ddl.c
@@ -405,12 +405,37 @@ gda_postgres_render_CREATE_TABLE (GdaServerProvider *provider, GdaConnection *cn
}
value = gda_server_operation_get_value_at (op, "/TABLE_DEF_P/TABLE_WITH_OIDS");
- if (value && G_VALUE_HOLDS (value, G_TYPE_BOOLEAN) && g_value_get_boolean (value))
- g_string_append (string, " WITH OIDS");
+ if (value && G_VALUE_HOLDS (value, G_TYPE_BOOLEAN) && g_value_get_boolean (value)) {
+ const gchar *server_version = gda_server_provider_get_server_version (provider, cnc);
+
+ if (server_version) {
+
+ gchar **setstring = g_strsplit(server_version, " ", -1);
+
+ if (setstring) {
+ const gchar *t_version = setstring[1]; // We need a second element from the array
+
+ if (t_version) {
+ if (!g_strcmp0(t_version, "9.4.26") ||
+ !g_strcmp0(t_version, "9.5.21") ||
+ !g_strcmp0(t_version, "9.6.17") ||
+ !g_strcmp0(t_version, "10.12") ||
+ !g_strcmp0(t_version, "11.7")) {
+ g_string_append (string, " WITH OIDS");
+ }
+ }
+
+ g_strfreev(setstring);
+ }
+ }
+ }
sql = string->str;
g_string_free (string, FALSE);
+#ifdef GDA_DEBUG
+ g_print ("Renderer SQL for PostgreSQL: %s\n", sql);
+#endif
return sql;
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]