[libnma/bg/cert-chooser-key] cert-chooser: don't clear the key when user sets non-pkcs12 certificate



commit 85a889d429a9a3927e2cfaacc3b259e117113ca3
Author: Beniamino Galvani <bgalvani redhat com>
Date:   Tue Jun 9 17:35:17 2020 +0200

    cert-chooser: don't clear the key when user sets non-pkcs12 certificate
    
    If the user sets a non-pkcs12 certificate we wrongly clear the key;
    fix this.
    
    Fixes: 7822b375753e ('cert-chooser: improving for handling certificate selection')
    
    https://gitlab.gnome.org/GNOME/NetworkManager-openvpn/-/issues/50

 src/nma-file-cert-chooser.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
---
diff --git a/src/nma-file-cert-chooser.c b/src/nma-file-cert-chooser.c
index ca84e730..27b764e8 100644
--- a/src/nma-file-cert-chooser.c
+++ b/src/nma-file-cert-chooser.c
@@ -222,11 +222,8 @@ cert_changed_cb (GtkFileChooserButton *file_chooser_button, gpointer user_data)
                                key = gtk_file_chooser_get_filename (GTK_FILE_CHOOSER (priv->key_button));
                                if (!nm_streq0 (cert, key))
                                        gtk_file_chooser_set_filename (GTK_FILE_CHOOSER (priv->key_button), 
cert);
-                       }
-                       else {
-                               gtk_file_chooser_unselect_all (GTK_FILE_CHOOSER (priv->key_button));
+                       } else
                                sensitive = TRUE;
-                       }
                } else
                        gtk_file_chooser_unselect_all (GTK_FILE_CHOOSER (priv->key_button));
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]