[gnome-shell/gbsneto/random-cleanups-pt1: 10/13] workspacesView: Override vfunc_hide



commit 8914a46669c8340f81d09d268c49e15aa0015856
Author: Georges Basile Stavracas Neto <georges stavracas gmail com>
Date:   Tue Jun 2 14:15:45 2020 -0300

    workspacesView: Override vfunc_hide
    
    Override the hide vfunc instead of the plain hide() method.
    
    https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1295

 js/ui/workspacesView.js | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)
---
diff --git a/js/ui/workspacesView.js b/js/ui/workspacesView.js
index b196427cc9..335344eb0a 100644
--- a/js/ui/workspacesView.js
+++ b/js/ui/workspacesView.js
@@ -393,7 +393,10 @@ class ExtraWorkspaceView extends WorkspacesViewBase {
 var WorkspacesDisplay = GObject.registerClass(
 class WorkspacesDisplay extends St.Widget {
     _init(scrollAdjustment) {
-        super._init({ clip_to_allocation: true });
+        super._init({
+            visible: false,
+            clip_to_allocation: true,
+        });
         this.connect('notify::allocation', this._updateWorkspacesActualGeometry.bind(this));
 
         let workspaceManager = global.workspace_manager;
@@ -609,6 +612,7 @@ class WorkspacesDisplay extends St.Widget {
     }
 
     animateToOverview(fadeOnPrimary) {
+        this.show();
         this._updateWorkspacesViews();
         for (let i = 0; i < this._workspacesViews.length; i++) {
             let animationType;
@@ -640,7 +644,7 @@ class WorkspacesDisplay extends St.Widget {
         }
     }
 
-    hide() {
+    vfunc_hide() {
         if (this._restackedNotifyId > 0) {
             Main.overview.disconnect(this._restackedNotifyId);
             this._restackedNotifyId = 0;
@@ -656,6 +660,8 @@ class WorkspacesDisplay extends St.Widget {
         for (let i = 0; i < this._workspacesViews.length; i++)
             this._workspacesViews[i].destroy();
         this._workspacesViews = [];
+
+        super.vfunc_hide();
     }
 
     _workspacesOnlyOnPrimaryChanged() {


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]