[gnome-shell/gbsneto/random-cleanups-pt1: 9/13] workspacesView: Rename show to animateToOverview
- From: Georges Basile Stavracas Neto <gbsneto src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell/gbsneto/random-cleanups-pt1: 9/13] workspacesView: Rename show to animateToOverview
- Date: Wed, 3 Jun 2020 15:56:18 +0000 (UTC)
commit e7ec373aeebf46f6096f98b4a8ee1ae1e3454405
Author: Georges Basile Stavracas Neto <georges stavracas gmail com>
Date: Mon Jun 1 12:20:44 2020 -0300
workspacesView: Rename show to animateToOverview
WorkspacesDisplay is a ClutterActor subclass, and overriding
the show and hide methods require chaining up, otherwise the
actor isn't actually shown or hidden.
To avoid clashing with the pre-existing show method, rename
to animateToOverview.
https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1295
js/ui/viewSelector.js | 2 +-
js/ui/workspacesView.js | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/js/ui/viewSelector.js b/js/ui/viewSelector.js
index 5c0dd9bb75..930e5b1e6d 100644
--- a/js/ui/viewSelector.js
+++ b/js/ui/viewSelector.js
@@ -273,7 +273,7 @@ var ViewSelector = GObject.registerClass({
show() {
this.reset();
- this._workspacesDisplay.show(this._showAppsButton.checked);
+ this._workspacesDisplay.animateToOverview(this._showAppsButton.checked);
this._activePage = null;
if (this._showAppsButton.checked)
this._showPage(this._appsPage);
diff --git a/js/ui/workspacesView.js b/js/ui/workspacesView.js
index 09155c5ae1..b196427cc9 100644
--- a/js/ui/workspacesView.js
+++ b/js/ui/workspacesView.js
@@ -608,7 +608,7 @@ class WorkspacesDisplay extends St.Widget {
return this._getPrimaryView().navigate_focus(from, direction, false);
}
- show(fadeOnPrimary) {
+ animateToOverview(fadeOnPrimary) {
this._updateWorkspacesViews();
for (let i = 0; i < this._workspacesViews.length; i++) {
let animationType;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]