[balsa] balsa-index: Do not scroll to first-unread

[Peter Bloomfield <peterb src gnome org>]

commit bb450d5d9595067cf65bcbbad2b5b70c71348cde
Author: Peter Bloomfield <PeterBloomfield bellsouth net>
Date:   Wed Jan 8 21:35:19 2020 -0500

    balsa-index: Do not scroll to first-unread
    
    Do not scroll to first-unread message when
    LibBalsaMailbox::changed signal is received.
    
    It is not needed, and it blocks scroll-on-open from scrolling to
    the first-unread message.
    
    * src/balsa-index.c (bndx_mailbox_changed_idle): do not clear
      LibBalsaMailbox:first_unread; and do not scroll to it, either.

 ChangeLog         | 11 +++++++++++
 src/balsa-index.c | 14 +-------------
 2 files changed, 12 insertions(+), 13 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index 2be82b1f2..b86bd574e 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,14 @@
+2020-01-08  Peter Bloomfield  <pbloomfield bellsouth net>
+
+       balsa-index: do not scroll to first-unread message when
+       LibBalsaMailbox::changed signal is received.
+
+       It is not needed, and it blocks scroll-on-open from scrolling to
+       the first-unread message.
+
+       * src/balsa-index.c (bndx_mailbox_changed_idle): do not clear
+       LibBalsaMailbox:first_unread; and do not scroll to it, either.
+
 2020-01-07  Peter Bloomfield  <pbloomfield bellsouth net>
 
        main-window: Avoid recursive entry
diff --git a/src/balsa-index.c b/src/balsa-index.c
index 18af005a4..789c64493 100644
--- a/src/balsa-index.c
+++ b/src/balsa-index.c
@@ -1377,22 +1377,10 @@ bndx_queue_draw_idle(gpointer data)
 static gboolean
 bndx_mailbox_changed_idle(BalsaIndex * bindex)
 {
-    LibBalsaMailbox *mailbox;
-    guint first_unread;
     GtkTreePath *path;
 
     bindex->mailbox_changed_idle_id = 0;
 
-    mailbox = balsa_mailbox_node_get_mailbox(bindex->mailbox_node);
-    first_unread = libbalsa_mailbox_get_first_unread(mailbox);
-    if (first_unread > 0
-        && libbalsa_mailbox_msgno_find(mailbox, first_unread,
-                                       &path, NULL)) {
-        bndx_expand_to_row(bindex, path);
-        gtk_tree_path_free(path);
-        libbalsa_mailbox_set_first_unread(mailbox, 0);
-    }
-
     if (bndx_find_current_msgno(bindex, &path, NULL)) {
         /* The thread containing the current message may have been
          * collapsed by rethreading; re-expand it. */
@@ -1407,7 +1395,7 @@ bndx_mailbox_changed_idle(BalsaIndex * bindex)
             g_idle_add((GSourceFunc) bndx_queue_draw_idle, bindex);
     }
 
-    return FALSE;
+    return G_SOURCE_REMOVE;
 }
 
 static void