[orca] Improve performance processing text-changed events from elements
- From: Joanmarie Diggs <joanied src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [orca] Improve performance processing text-changed events from elements
- Date: Mon, 20 Apr 2020 22:33:37 +0000 (UTC)
commit 3a7e9f149d0c33add74e6c14c597301d52d8c05c
Author: Joanmarie Diggs <jdiggs igalia com>
Date: Mon Apr 20 18:30:19 2020 -0400
Improve performance processing text-changed events from elements
* Identify and handle live region events sooner than we were
* Return early if we suspect the events are from a page switch
* Move the quicker checks ahead of the less performant checks
src/orca/scripts/web/script.py | 59 ++++++++++++++++++++++++++----------------
1 file changed, 37 insertions(+), 22 deletions(-)
---
diff --git a/src/orca/scripts/web/script.py b/src/orca/scripts/web/script.py
index 8866a3c51..7ee4d28ae 100644
--- a/src/orca/scripts/web/script.py
+++ b/src/orca/scripts/web/script.py
@@ -2074,6 +2074,16 @@ class Script(default.Script):
debug.println(debug.LEVEL_INFO, msg, True)
return True
+ if self.utilities.lastInputEventWasPageSwitch():
+ msg = "WEB: Deletion is believed to be due to page switch"
+ debug.println(debug.LEVEL_INFO, msg, True)
+ return True
+
+ if self.utilities.isLiveRegion(event.source):
+ msg = "WEB: Ignoring deletion from live region"
+ debug.println(debug.LEVEL_INFO, msg, True)
+ return True
+
if self.utilities.eventIsBrowserUINoise(event):
msg = "WEB: Ignoring event believed to be browser UI noise"
debug.println(debug.LEVEL_INFO, msg, True)
@@ -2084,8 +2094,13 @@ class Script(default.Script):
debug.println(debug.LEVEL_INFO, msg, True)
return False
- if self.utilities.eventIsAutocompleteNoise(event):
- msg = "WEB: Ignoring event believed to be autocomplete noise"
+ if self.utilities.textEventIsDueToDeletion(event):
+ msg = "WEB: Event believed to be due to editable text deletion"
+ debug.println(debug.LEVEL_INFO, msg, True)
+ return False
+
+ if self.utilities.textEventIsDueToInsertion(event):
+ msg = "WEB: Ignoring event believed to be due to text insertion"
debug.println(debug.LEVEL_INFO, msg, True)
return True
@@ -2094,13 +2109,8 @@ class Script(default.Script):
debug.println(debug.LEVEL_INFO, msg, True)
return True
- if self.utilities.textEventIsDueToDeletion(event):
- msg = "WEB: Event believed to be due to editable text deletion"
- debug.println(debug.LEVEL_INFO, msg, True)
- return False
-
- if self.utilities.textEventIsDueToInsertion(event):
- msg = "WEB: Ignoring event believed to be due to text insertion"
+ if self.utilities.eventIsAutocompleteNoise(event):
+ msg = "WEB: Ignoring event believed to be autocomplete noise"
debug.println(debug.LEVEL_INFO, msg, True)
return True
@@ -2157,6 +2167,22 @@ class Script(default.Script):
debug.println(debug.LEVEL_INFO, msg, True)
return True
+ if self.utilities.lastInputEventWasPageSwitch():
+ msg = "WEB: Insertion is believed to be due to page switch"
+ debug.println(debug.LEVEL_INFO, msg, True)
+ return True
+
+ if self.utilities.handleAsLiveRegion(event):
+ msg = "WEB: Event to be handled as live region"
+ debug.println(debug.LEVEL_INFO, msg, True)
+ self.liveRegionManager.handleEvent(event)
+ return True
+
+ if self.utilities.eventIsEOCAdded(event):
+ msg = "WEB: Ignoring: Event was for embedded object char"
+ debug.println(debug.LEVEL_INFO, msg, True)
+ return True
+
if self.utilities.eventIsBrowserUINoise(event):
msg = "WEB: Ignoring event believed to be browser UI noise"
debug.println(debug.LEVEL_INFO, msg, True)
@@ -2167,18 +2193,13 @@ class Script(default.Script):
debug.println(debug.LEVEL_INFO, msg, True)
return False
- if self.utilities.eventIsAutocompleteNoise(event):
- msg = "WEB: Ignoring: Event believed to be autocomplete noise"
- debug.println(debug.LEVEL_INFO, msg, True)
- return True
-
if self.utilities.eventIsSpinnerNoise(event):
msg = "WEB: Ignoring: Event believed to be spinner noise"
debug.println(debug.LEVEL_INFO, msg, True)
return True
- if self.utilities.eventIsEOCAdded(event):
- msg = "WEB: Ignoring: Event was for embedded object char"
+ if self.utilities.eventIsAutocompleteNoise(event):
+ msg = "WEB: Ignoring: Event believed to be autocomplete noise"
debug.println(debug.LEVEL_INFO, msg, True)
return True
@@ -2186,12 +2207,6 @@ class Script(default.Script):
debug.println(debug.LEVEL_INFO, msg, True)
self.utilities.clearContentCache()
- if self.utilities.handleAsLiveRegion(event):
- msg = "WEB: Event to be handled as live region"
- debug.println(debug.LEVEL_INFO, msg, True)
- self.liveRegionManager.handleEvent(event)
- return True
-
document = self.utilities.getDocumentForObject(event.source)
if document:
msg = "WEB: Clearing structural navigation cache for %s" % document
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]