[gnome-shell/wip/fmuellner/double-destroy: 2/2] windowAttentionHandler: Don't destroy on open



commit 26e33ff0933d3386cd2428b96b2280dc8d9aebaa
Author: Florian Müllner <fmuellner gnome org>
Date:   Sat Mar 2 21:15:03 2019 +0100

    windowAttentionHandler: Don't destroy on open
    
    The activateWindow() call is expected to focus the window, which
    already destroys the source. If we then destroy it again explicitly,
    we get another "invalid access" warning.
    
    https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/430

 js/ui/windowAttentionHandler.js | 1 -
 1 file changed, 1 deletion(-)
---
diff --git a/js/ui/windowAttentionHandler.js b/js/ui/windowAttentionHandler.js
index 27b342b00..abdb8a444 100644
--- a/js/ui/windowAttentionHandler.js
+++ b/js/ui/windowAttentionHandler.js
@@ -101,6 +101,5 @@ var Source = class WindowAttentionSource extends MessageTray.Source {
 
     open() {
         Main.activateWindow(this._window);
-        this.destroy();
     }
 };


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]