[gnome-shell/wip/fmuellner/double-destroy: 1/2] network: Don't destroy wireless dialog twice
- From: Florian Müllner <fmuellner src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell/wip/fmuellner/double-destroy: 1/2] network: Don't destroy wireless dialog twice
- Date: Sat, 2 Mar 2019 21:11:49 +0000 (UTC)
commit 5f2bd7069021582d16c6a329ccaeaa269c73a3ac
Author: Florian Müllner <fmuellner gnome org>
Date: Sat Mar 2 20:46:28 2019 +0100
network: Don't destroy wireless dialog twice
The dialog doesn't change the `destroyOnClose` property from its default,
so it is already destroyed automatically on close. So if we also destroy
it explicitly, we end up (rightfully) with one of gjs' infamous "invalid
access" warnings.
https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/430
js/ui/status/network.js | 1 -
1 file changed, 1 deletion(-)
---
diff --git a/js/ui/status/network.js b/js/ui/status/network.js
index 21cbeac61..77a6202b8 100644
--- a/js/ui/status/network.js
+++ b/js/ui/status/network.js
@@ -1236,7 +1236,6 @@ var NMDeviceWireless = class {
}
_dialogClosed() {
- this._dialog.destroy();
this._dialog = null;
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]