[gnome-music/wip/jfelder/tag-test: 22/22] fix flake8 issues

[Jean Felder <jfelder src gnome org>]

commit cbf53968ca3f5b4469403b521cd3af5009d29af0
Author: Jean Felder <jfelder src gnome org>
Date:   Mon Jul 29 18:15:45 2019 +0200

    fix flake8 issues

 gnomemusic/musicbrainz.py             |  6 +++---
 gnomemusic/utils.py                   | 30 ++++++++++++++++--------------
 gnomemusic/widgets/tageditordialog.py | 11 +++++++----
 3 files changed, 26 insertions(+), 21 deletions(-)
---
diff --git a/gnomemusic/musicbrainz.py b/gnomemusic/musicbrainz.py
index 94db94e6..fd748d22 100644
--- a/gnomemusic/musicbrainz.py
+++ b/gnomemusic/musicbrainz.py
@@ -70,7 +70,7 @@ class MusicBrainz(GObject.GObject):
 
     def _add_new_source(self, klass, source):
         source_id = source.get_id()
-        print ("Add new source called with id", source_id)
+        print("Add new source called with id", source_id)
         if source_id in self._needed_sources:
             self._sources[source_id] = source
 
@@ -94,7 +94,8 @@ class MusicBrainz(GObject.GObject):
         return (self.props.chromaprint_available
                 and self.props.acoustid_available)
 
-    def _acoustid_resolved(self, source, op_id, media, count, callback, error=None):
+    def _acoustid_resolved(
+            self, source, op_id, media, count, callback, error=None):
         if error:
             logger.warning("Error {}: {}".format(error.domain, error.message))
             return callback(None, 0)
@@ -109,7 +110,6 @@ class MusicBrainz(GObject.GObject):
         options = Grl.OperationOptions()
         options.set_resolution_flags(Grl.ResolutionFlags.NORMAL)
 
-        error = None
         query = 'duration=' + str(media.get_duration())
         query += '&fingerprint=' + media.get_string(self._fingerprint_key)
 
diff --git a/gnomemusic/utils.py b/gnomemusic/utils.py
index 3a024ef9..af03251c 100644
--- a/gnomemusic/utils.py
+++ b/gnomemusic/utils.py
@@ -31,6 +31,7 @@ from gi.repository import Gio, GLib, Grl
 
 from gnomemusic.grilo import grilo
 
+
 class View(IntEnum):
     """Enum for views"""
     EMPTY = 0
@@ -162,8 +163,8 @@ def set_album_title(item, album):
     :param item: A Grilo Media object
     :param album: A string representing album title
     """
-    return ( item.set_album(album) and
-             grilo.set_metadata_key(item, Grl.METADATA_KEY_ALBUM) )
+    return (item.set_album(album) and
+            grilo.set_metadata_key(item, Grl.METADATA_KEY_ALBUM))
 
 
 def set_artist_name(item, artist):
@@ -172,8 +173,8 @@ def set_artist_name(item, artist):
     :param item: A Grilo Media object
     :param album: A string representing artist name
     """
-    return ( item.set_artist(artist) and
-             grilo.set_metadata_key(item, Grl.METADATA_KEY_ARTIST) )
+    return (item.set_artist(artist) and
+            grilo.set_metadata_key(item, Grl.METADATA_KEY_ARTIST))
 
 
 def set_album_disc_number(item, disc_number):
@@ -182,8 +183,8 @@ def set_album_disc_number(item, disc_number):
     :param item: A Grilo Media object
     :param album: A string representing album disc number
     """
-    return ( item.set_album_disc_number(int(disc_number)) and
-             grilo.set_metadata_key(item, Grl.METADATA_KEY_ALBUM_DISC_NUMBER) )
+    return (item.set_album_disc_number(int(disc_number)) and
+            grilo.set_metadata_key(item, Grl.METADATA_KEY_ALBUM_DISC_NUMBER))
 
 
 def set_title(item, title):
@@ -192,8 +193,8 @@ def set_title(item, title):
     :param item: A Grilo Media object
     :param album: A string representing title
     """
-    return ( item.set_title(title) and
-             grilo.set_metadata_key(item, Grl.METADATA_KEY_TITLE) )
+    return (item.set_title(title) and
+            grilo.set_metadata_key(item, Grl.METADATA_KEY_TITLE))
 
 
 def set_track_number(item, track_number):
@@ -202,8 +203,8 @@ def set_track_number(item, track_number):
     :param item: A Grilo Media object
     :param album: A string representing track number
     """
-    return ( item.set_track_number(int(track_number)) and
-             grilo.set_metadata_key(item, Grl.METADATA_KEY_TRACK_NUMBER) )
+    return (item.set_track_number(int(track_number)) and
+            grilo.set_metadata_key(item, Grl.METADATA_KEY_TRACK_NUMBER))
 
 
 def set_creation_year(item, creation_year):
@@ -220,10 +221,10 @@ def set_creation_year(item, creation_year):
         hour = creation_date.get_hour()
         minute = creation_date.get_minute()
         second = creation_date.get_second()
-        updated_creation_date = GLib.DateTime(timezone, int(creation_year), month, day, hour, minute, second)
-        return ( item.set_creation_date(updated_creation_date) and
-                 grilo.set_metadata_key(item, Grl.METADATA_KEY_CREATION_DATE) )
-
+        updated_creation_date = GLib.DateTime(
+            timezone, int(creation_year), month, day, hour, minute, second)
+        return (item.set_creation_date(updated_creation_date) and
+                grilo.set_metadata_key(item, Grl.METADATA_KEY_CREATION_DATE))
 
 
 fields_getter = {
@@ -235,6 +236,7 @@ fields_getter = {
     'year': get_media_year
 }
 
+
 fields_setter = {
     'album': set_album_title,
     'artist': set_artist_name,
diff --git a/gnomemusic/widgets/tageditordialog.py b/gnomemusic/widgets/tageditordialog.py
index 152ef166..aeca06b2 100644
--- a/gnomemusic/widgets/tageditordialog.py
+++ b/gnomemusic/widgets/tageditordialog.py
@@ -30,7 +30,7 @@ from gi.repository import Grl, Gtk, Gio, GObject, GLib
 from gnomemusic import log
 from gnomemusic.albumartcache import Art
 from gnomemusic.grilo import grilo
-from gnomemusic.widgets.notificationspopup import NotificationsPopup, UseSuggestionNotification
+from gnomemusic.widgets.notificationspopup import UseSuggestionNotification
 import gnomemusic.utils as utils
 
 logger = logging.getLogger(__name__)
@@ -93,7 +93,8 @@ class TagEditorDialog(Gtk.Dialog):
         self._cover_stack.props.size = Art.Size.LARGE
         self._cover_stack.update(selected_song)
 
-        self._music_directory = GLib.get_user_special_dir(GLib.UserDirectory.DIRECTORY_MUSIC)
+        self._music_directory = GLib.get_user_special_dir(
+            GLib.UserDirectory.DIRECTORY_MUSIC)
 
         self._initial_song = selected_song
         self._init_labels()
@@ -115,7 +116,8 @@ class TagEditorDialog(Gtk.Dialog):
         file_path = file_.get_path()
         if file_path.startswith(self._music_directory):
             self._url.set_text(file_path[len(self._music_directory)+1:])
-            self._url.set_tooltip_text(file_path[len(self._music_directory)+1:])
+            self._url.set_tooltip_text(
+                file_path[len(self._music_directory)+1:])
             self._url.set_has_tooltip(True)
         else:
             self._url.set_text(file_path)
@@ -193,7 +195,8 @@ class TagEditorDialog(Gtk.Dialog):
                 self._submit_button.props.sensitive = True
             if self._pointer >= 0:
                 suggested_value = utils.fields_getter[field](media)
-                if typed_value and suggested_value and typed_value != suggested_value:
+                if (typed_value and suggested_value
+                        and typed_value != suggested_value):
                     self._use_suggestion_button.props.sensitive = True
 
     @Gtk.Template.Callback()