[gnome-commander] Do not implicitely define the deconstructor of the SearchProfile



commit ef202396765b3bee743f0fa7a2fff20f7ae3e46c
Author: Uwe Scholz <u scholz83 gmx de>
Date:   Sun Jan 27 21:53:26 2019 +0100

    Do not implicitely define the deconstructor of the SearchProfile
    
    This should fix a build warning in Ubuntu:
    
    In file included from gnome-cmd-search-dialog.cc:27:
    ./../gnome-cmd-data.h: In static member function 'static void GnomeCmd::ManageProfilesDialog<CONFIG, 
PROFILE, COMPONENT>::edit_clicked_callback(GtkButton*, GtkWidget*) [with CONFIG = GnomeCmdData::SearchConfig; 
PROFILE = GnomeCmdData::SearchProfile; COMPONENT = GnomeCmdSelectionProfileComponent]':
    ./../gnome-cmd-data.h:533:12: error: inlining failed in call to 
'GnomeCmdData::SearchProfile::~SearchProfile() noexcept': call is unlikely and code size would grow 
[-Werror=inline]
         struct SearchProfile
                ^~~~~~~~~~~~~
    In file included from gnome-cmd-search-dialog.cc:35:
    gnome-cmd-manage-profiles-dialog.h:220:21: note: called from here
                 PROFILE p = profiles[idx];
                         ^

 src/gnome-cmd-data.cc | 3 +++
 src/gnome-cmd-data.h  | 2 ++
 2 files changed, 5 insertions(+)
---
diff --git a/src/gnome-cmd-data.cc b/src/gnome-cmd-data.cc
index 6799ebe8..7e0655b8 100644
--- a/src/gnome-cmd-data.cc
+++ b/src/gnome-cmd-data.cc
@@ -4313,6 +4313,9 @@ GtkSortType GnomeCmdData::get_sort_direction(FileSelectorID id) const
 }
 
 
+GnomeCmdData::SearchProfile::~SearchProfile(){};
+
+
 gpointer gnome_cmd_data_get_con_list ()
 {
     return gnome_cmd_data.priv->con_list;
diff --git a/src/gnome-cmd-data.h b/src/gnome-cmd-data.h
index 0d4525ea..d7268e83 100644
--- a/src/gnome-cmd-data.h
+++ b/src/gnome-cmd-data.h
@@ -542,6 +542,8 @@ struct GnomeCmdData
 
         const std::string &description() const    {  return filename_pattern;  }
         void reset();
+
+        ~SearchProfile();
     };
 
     struct SearchConfig


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]