[gnome-software] flatpak: Remove some error prefixes



commit 4db7f4dd5b1f98cef51d5e77489d42421bb21e24
Author: Kalev Lember <klember redhat com>
Date:   Sat Jan 26 20:16:03 2019 +0100

    flatpak: Remove some error prefixes
    
    They made the error notifications super long and hard to read, for
    example:
    
    Unable to install "Eye of GNOME":
    failed to add install ref app/org.gnome.eog/x86_64/stable:
    org.gnome.eog/x86_64/stable is already installed from remote fedora
    
    This commit simplifies it so it just reads:
    
    Unable to install "Eye of GNOME":
    org.gnome.eog/x86_64/stable is already installed from remote fedora

 plugins/flatpak/gs-plugin-flatpak.c | 5 -----
 1 file changed, 5 deletions(-)
---
diff --git a/plugins/flatpak/gs-plugin-flatpak.c b/plugins/flatpak/gs-plugin-flatpak.c
index b4f059ce..bd806825 100644
--- a/plugins/flatpak/gs-plugin-flatpak.c
+++ b/plugins/flatpak/gs-plugin-flatpak.c
@@ -473,7 +473,6 @@ gs_plugin_download (GsPlugin *plugin, GsAppList *list,
 
                ref = gs_flatpak_app_get_ref_display (app);
                if (!flatpak_transaction_add_update (transaction, ref, NULL, NULL, error)) {
-                       g_prefix_error (error, "failed to add update ref %s: ", ref);
                        gs_flatpak_error_convert (error);
                        return FALSE;
                }
@@ -512,7 +511,6 @@ gs_plugin_app_remove (GsPlugin *plugin,
        }
        ref = gs_flatpak_app_get_ref_display (app);
        if (!flatpak_transaction_add_uninstall (transaction, ref, error)) {
-               g_prefix_error (error, "failed to add uninstall ref %s: ", ref);
                gs_flatpak_error_convert (error);
                return FALSE;
        }
@@ -637,7 +635,6 @@ gs_plugin_app_install (GsPlugin *plugin,
                if (!flatpak_transaction_add_install_bundle (transaction, file,
                                                             NULL, error)) {
                        g_autofree gchar *fn = g_file_get_path (file);
-                       g_prefix_error (error, "failed to add install ref %s: ", fn);
                        gs_flatpak_error_convert (error);
                        return FALSE;
                }
@@ -648,7 +645,6 @@ gs_plugin_app_install (GsPlugin *plugin,
                if (!flatpak_transaction_add_install (transaction,
                                                      gs_app_get_origin (app),
                                                      ref, NULL, error)) {
-                       g_prefix_error (error, "failed to add install ref %s: ", ref);
                        gs_flatpak_error_convert (error);
                        return FALSE;
                }
@@ -711,7 +707,6 @@ gs_plugin_update (GsPlugin *plugin,
 
                ref = gs_flatpak_app_get_ref_display (app);
                if (!flatpak_transaction_add_update (transaction, ref, NULL, NULL, error)) {
-                       g_prefix_error (error, "failed to add update ref %s: ", ref);
                        gs_flatpak_error_convert (error);
                        return FALSE;
                }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]