[shotwell] Stop spinning the event loop when changing cursors



commit 1a0be71e0eb110ae5ca19dc1c1ac3a583d0ce5bf
Author: Jens Georg <mail jensge org>
Date:   Sat Oct 13 21:22:00 2018 +0200

    Stop spinning the event loop when changing cursors
    
    Tihs was added as part of 9dd0e31d0ac1f7768050f9acc09d2375578cded0 with
    no particular reason.
    
    Spinning the event loop causes code to be run in non-expected order in
    at least one place when cancelling the import, leading to use-after-free
    
    Unfortunately I have no idea on the side-effects that removing this will
    cause. Time will tell.
    
    Fixes #58

 src/AppWindow.vala | 2 --
 1 file changed, 2 deletions(-)
---
diff --git a/src/AppWindow.vala b/src/AppWindow.vala
index 6b0868e5..892979e4 100644
--- a/src/AppWindow.vala
+++ b/src/AppWindow.vala
@@ -367,7 +367,6 @@ public abstract class PageWindow : Gtk.ApplicationWindow {
         var display = get_window ().get_display ();
         var cursor = new Gdk.Cursor.for_display (display, Gdk.CursorType.WATCH);
         get_window().set_cursor (cursor);
-        spin_event_loop();
     }
     
     public void set_normal_cursor() {
@@ -381,7 +380,6 @@ public abstract class PageWindow : Gtk.ApplicationWindow {
         var display = get_window ().get_display ();
         var cursor = new Gdk.Cursor.for_display (display, Gdk.CursorType.LEFT_PTR);
         get_window().set_cursor (cursor);
-        spin_event_loop();
     }
     
 }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]