[pygobject] resulttuple: fix a wrong decref



commit 42bc3ad06a1aa602a63a501a7529ea68d6654a83
Author: Christoph Reiter <reiter christoph gmail com>
Date:   Sun Mar 25 19:12:54 2018 +0200

    resulttuple: fix a wrong decref
    
    We don't get ownership here so don't unref.
    Thist function is only used in the test suite.

 gi/pygi-resulttuple.c     | 2 --
 tests/test_resulttuple.py | 6 ++++--
 2 files changed, 4 insertions(+), 4 deletions(-)
---
diff --git a/gi/pygi-resulttuple.c b/gi/pygi-resulttuple.c
index 29170176..b2212aff 100644
--- a/gi/pygi-resulttuple.c
+++ b/gi/pygi-resulttuple.c
@@ -158,13 +158,11 @@ resulttuple_new_type(PyObject *self, PyObject *args) {
         return NULL;
 
     if (!PyList_Check (tuple_names)) {
-        Py_DECREF (tuple_names);
         PyErr_SetString (PyExc_TypeError, "not a list");
         return NULL;
     }
 
     new_type = (PyObject *)pygi_resulttuple_new_type (tuple_names);
-    Py_DECREF (tuple_names);
     return new_type;
 }
 
diff --git a/tests/test_resulttuple.py b/tests/test_resulttuple.py
index 1a4aadf9..45764952 100644
--- a/tests/test_resulttuple.py
+++ b/tests/test_resulttuple.py
@@ -37,8 +37,10 @@ class TestResultTuple(unittest.TestCase):
         self.assertTrue(issubclass(ResultTuple, tuple))
 
     def test_create(self):
-        new = ResultTuple._new_type([None, "foo", None, "bar"])
-        self.assertTrue(issubclass(new, ResultTuple))
+        names = [None, "foo", None, "bar"]
+        for i in range(10):
+            new = ResultTuple._new_type(names)
+            self.assertTrue(issubclass(new, ResultTuple))
 
     def test_repr_dir(self):
         new = ResultTuple._new_type([None, "foo", None, "bar"])


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]