[gnome-software] plugin loader: Don't abort() for refine errors



commit 5b24280921bee7fd7ad045641fe7afecf39d8130
Author: Kalev Lember <klember redhat com>
Date:   Tue Mar 13 22:22:27 2018 +0100

    plugin loader: Don't abort() for refine errors
    
    When refining a wildcard app fails, don't abort(), but instead warn and
    return NULL. Refining can fail legitimately, e.g. when there's no
    network access to refine a system app with pkgdb data.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1554986

 lib/gs-plugin-loader.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/lib/gs-plugin-loader.c b/lib/gs-plugin-loader.c
index 55d8dde8..6e956b82 100644
--- a/lib/gs-plugin-loader.c
+++ b/lib/gs-plugin-loader.c
@@ -3749,7 +3749,7 @@ gs_plugin_loader_app_create (GsPluginLoader *plugin_loader, const gchar *unique_
        plugin_job = gs_plugin_job_newv (GS_PLUGIN_ACTION_REFINE, NULL);
        helper = gs_plugin_loader_helper_new (plugin_loader, plugin_job);
        if (!gs_plugin_loader_run_refine (helper, list, NULL, &error)) {
-               g_error ("%s", error->message);
+               g_warning ("%s", error->message);
                return NULL;
        }
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]